Obsidian Hangs when a new regular expression is added

[mattcoleanderson]

Problem

When adding a custom regex pattern int the plugins settings, Obsidian freezes with the following error logged to console:

Uncaught SyntaxError: Invalid regular expression: /(/dgm: Unterminated group (at plugin:dynamic-text-concealer:316:31)
    at new RegExp (<anonymous>)
    at eval (plugin:dynamic-text-concealer:316:31)
    at Array.forEach (<anonymous>)
    at ConcealPlugin.addEditorExtension (plugin:dynamic-text-concealer:310:34)
    at ConcealPlugin.updateEditorExtension (plugin:dynamic-text-concealer:322:14)
    at eval (plugin:dynamic-text-concealer:39:33)
    at t.onChanged (app.js:1:1320966)

Cause

When writing a new regex pattern in settings, the pattern is instantiated to a RegExp object prematurely.

Solution

The following changes need to be made:

• A try-catch block around the RegExp instantiation
• A save button in settings for the user to signify the regexp is ready for use