Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it would be nice if delocate-fuse would rename its output #174

Closed
glyph opened this issue Jan 26, 2023 · 4 comments
Closed

it would be nice if delocate-fuse would rename its output #174

glyph opened this issue Jan 26, 2023 · 4 comments

Comments

@glyph
Copy link

glyph commented Jan 26, 2023

Is your feature request related to a problem? Please describe.
delocate-fuse creates a universal2 wheel (which is amazing) but gives it the wrong tag

Describe the solution you'd like
Do not rewrite the input in place, instead, put a wheel next to it with a modified tag name.

Describe alternatives you've considered
It is not clear to me what other behavior would be correct :)

Additional context
I'm not sure if this is a feature or a bug. It strikes me as incorrect behavior to write an x86_64 tagged wheel that has arm64 code in it, but I am filing it as an enhancement as I assume the existing behavior has some reason for existing.

@matthew-brett
Copy link
Owner

I'm afraid the reason it hasn't changed is because - it started that way. Would you be interested in changing it to give the correct tag instead, with a --retag optional flag to trigger that behavior (for back-compatibility)?

@henryborchers
Copy link

@matthew-brett I'd think you'd want renaming to be the default.
When you create a universal2 wheel, it's until it's properly named, it is useless at as best and harmful at worst because it no longer reflects the contents of the wheel correctly. If someone wants the existing behavior, they should opt in, not the other way. Even if this is a breaking chance for some scripts.

@Doondondon

This comment was marked as duplicate.

@HexDecimal
Copy link
Collaborator

Closed by PR #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants