Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the code more Crystalline #1

Open
mattkimmel opened this issue Jan 10, 2021 · 0 comments
Open

Make the code more Crystalline #1

mattkimmel opened this issue Jan 10, 2021 · 0 comments

Comments

@mattkimmel
Copy link
Owner

The initial code for this project was copied and pasted directly from https://github.com/mak-it/bin_packing, and then modified as minimally as possible to get tests passing in Crystal.

It would be good to audit the code and do a few things, including but not limited to:

  • Changing Ruby idioms to Crystal idioms where possible
  • Putting in more explicit typing--the type inference engine is doing a lot of work and the code isn't all that readable
  • Fixing up the specs a bit, e.g. should eq true becomes should be_true, and so on

This is probably an ongoing task, but here's an issue to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant