Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port or re-implement HTML export #2

Open
mattkimmel opened this issue Jan 10, 2021 · 0 comments
Open

Port or re-implement HTML export #2

mattkimmel opened this issue Jan 10, 2021 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@mattkimmel
Copy link
Owner

For the initial version of this lib, the one thing I didn't port from https://github.com/mak-it/bin_packing is the HTML export. @mak-it uses Ruby's ERB engine for this, but Crystal's ECR engine is significantly more limited. Maybe I'm missing a way to use the original template with ECR, but it also might be worth re-implementing this using a different templating lib (or just re-implementing from scratch). It would be cool to be able to use the original templates, to make it easier to pull updates from the Ruby project.

@mattkimmel mattkimmel added the help wanted Extra attention is needed label Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant