-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add luxon date adapter #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, thank you!! I have never used luxon before so I had a few questions, no worries if they're not applicable (and I guess if the test suite passes, it's all ok)
My latest changes should cover all your suggestions. We probably have to update the |
Ah I see, please rebase on main, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will merge and release once the CI is fixed (I tried to do it myself but github blocked me)
Alright, we should be good to go now! |
It looks like the tests are failing, please can you commit the updated snapshots? https://github.com/mattlewis92/calendar-utils/actions/runs/11175436044/job/31217858636?pr=52 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 508 559 +51
Branches 95 95
=========================================
+ Hits 508 559 +51 ☔ View full report in Codecov by Sentry. |
Published as |
I have completed the Luxon date-adapter in reference to this pull request: mattlewis92/angular-calendar#1709.
It would be appreciated if we could get this merged and released. I am also prepared to proceed with adding Luxon support to the main repository.
Thank you!