-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for Bls12381G1 KeyPair #15
Comments
All of the APIs are now exposed in bbs-signatures |
The functionality in Bls12381G2KeyPair essentially needs to be replicated in the context of G1 |
This adds support for Bls12381G1 KeyPairs, but the signer factory and verifier factories which use @mattrglobal/bbs-signatures still need to be updated before sign and verify will work properly. re: issue #15 Signed-off-by: Kyle Den Hartog <kyle.denhartog@mattr.global>
* feat: adds support for Bls12381G1KeyPairs This adds support for Bls12381G1 KeyPairs, but the signer factory and verifier factories which use @mattrglobal/bbs-signatures still need to be updated before sign and verify will work properly. re: issue #15 Signed-off-by: Kyle Den Hartog <kyle.denhartog@mattr.global> * Update multicodec byte comment for Bls12381G1 Co-authored-by: Tobias Looker <tobias.looker@mattr.global> * fix: removes functionality for signer and verify in bls12381G1KeyPair this removes the sign and verifier factories as well as the tests to check sign and verify for Bls12381G1KeyPair. The BBS+ signatures library needs to be updated before this functionality will work for signing and verifying with G1 key pairs. Co-authored-by: Tobias Looker <tobias.looker@mattr.global>
#26 got most of this done. There still remains some work to finish this which depends on mattrglobal/bbs-signatures#52 to finish |
@tplooker @kdenhartog bump on this :) unstable says "Not Implemented" |
We've got support for the representation at this point, but not the usage (signer and verifier functions which were temporarily deleted in #26). Some of the Rust code still needs to be updated so we can use the G1 keypairs with the BBS Signatures which is why the unstable release still shows as "Not Implemented" (assuming I understand what you're referring to correctly). I think in the thick of it this work got de-prioritized at the moment while we're working through some of the other related issues with contexts at the higher layers. We'll eventually get around to finishing it up, but if you've got an immediate need for it happy to review PRs and help get it through for you. |
I don't have a use for it until we have a plan for it in https://github.com/w3c-ccg/ldp-bbs2020 I added support for both key pairs to did key over the weekend, here is a demo:
|
Some BLS and BBS signatures will involve the usage of a public key in G1, hence support should be added
The text was updated successfully, but these errors were encountered: