[#66] update zgw-consumers #278
Conversation
SonnyBA
force-pushed
the
issue/66-zgw-consumers-update
branch
from
894e92b
to
7a6a8bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 96.89% 96.98% +0.08%
==========================================
Files 146 156 +10
Lines 6444 7120 +676
==========================================
+ Hits 6244 6905 +661
- Misses 200 215 +15 ☔ View full report in Codecov by Sentry. |
SonnyBA
force-pushed
the
issue/66-zgw-consumers-update
branch
from
af5094b
to
920d96d
Compare
requirements/base.in
Outdated
| @@ -1 +1,3 @@ | |||
| open-api-framework | |||
|
|
|||
| git+https://github.com/maykinmedia/commonground-api-common@feature/update-notifs-client | |||
There was a problem hiding this comment.
Once this is released, we should bump it in open-api-framework and then bump that instead. Open Klant doesn't seem to be affected by the zgw-consumers update, so let's keep this PR open and change it once the releases are done
There was a problem hiding this comment.
This also applies to open-zaak/open-zaak#1800 and open-zaak/open-notificaties#196 and the upcoming PR's for the other projects too.
requirements/base.txt
Outdated
| @@ -105,6 +111,7 @@ django==4.2.15 | |||
| # notifications-api-common | |||
| # open-api-framework | |||
| # zgw-consumers | |||
| # zgw-consumers-oas | |||
There was a problem hiding this comment.
wait why do we need this dep? I don't remember this being part of commonground-api-common
|
This requires a new |
requirements/base.in
Outdated
| @@ -1 +1,3 @@ | |||
| open-api-framework | |||
|
|
|||
| commonground-api-common>=2.0.1 | |||
There was a problem hiding this comment.
this can be upgraded to 2.1.0
SonnyBA
force-pushed
the
issue/66-zgw-consumers-update
branch
from
b92a0a6
to
a96a892
Compare
Partially fixes maykinmedia/open-api-framework#66