🏹 Upgrade Elixir version #1024

Whoops · 2024-10-24T17:22:24Z

Summary of changes

Asana Ticket: 🏹 Upgrade Elixir version

Reviewer Checklist

Meets ticket's acceptance criteria
Any new or changed functions have typespecs
Tests were added for any new functionality (don't just rely on Codecov)
This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

Whoops · 2024-10-24T17:30:48Z

config/runtime.exs

@@ -56,8 +56,7 @@ if config_env() == :prod do
      root_source_code_path: File.cwd!(),
      tags: %{
        env: sentry_env
-      },
-      included_environments: [sentry_env]


https://hexdocs.pm/sentry/upgrade-10-x.html#stop-using-included_environments

Whoops · 2024-10-24T17:33:03Z

lib/arrow/disruption_revision.ex

@@ -285,4 +285,12 @@ defmodule Arrow.DisruptionRevision do
        changeset
    end
  end
+
+  defp date_range(start_date, end_date) do


Address new deprecation warnings where it's required to provide a step of -1 if end_date > start_date

I think the code below is correct but what you meant in this comment was start_date > end_date for step of -1 (so it enumerates backwards in time from start_date to end_date)

Whoops · 2024-10-24T17:34:17Z

mix.exs

-      {:httpoison, "~> 1.6"},
-      {:ja_serializer, github: "mbta/ja_serializer", branch: "master"},
+      {:httpoison, "~> 2.2"},
+      {:ja_serializer, "~> 0.18.0"},


Our version of ja_serializer has diverged from upstream, but also not been touched in 3 years. Best I could tell Arrow does not appear to rely on any MBTA specific behaviors.

I'm in support of this change since our version hasn't been maintained.

Was this upgrade of ja_serializer required as part of upgrading the elixir version though?

Can we split this change into it's own separate PR? If we notice any unexpected changes (like with the gtfs_creator build when parsing API results, performance issues with endpoints, whatever), it'd be easier to isolate that way.

Looks like it can be. Some of these depredations were forced since we compile with --warnings-as-errors in the test phase, but while keeping ja_serializer generates warnings during tests, it seems to compile happily. I've split it into #1026

Whoops · 2024-10-24T17:36:17Z

test/arrow_web/controllers/shape_controller_test.exs

@@ -141,18 +134,6 @@ defmodule ArrowWeb.ShapeControllerTest do
      assert html_response(conn, 200) =~ "Components.ShapeViewMap"
    end

-    @tag :authenticated_admin


This was fixed in this pr, that was released in 1.3.0, so these now parse correctly.

Whoops · 2024-10-24T17:40:36Z

lib/arrow_web/components/core_components.ex

@@ -17,7 +17,7 @@ defmodule ArrowWeb.CoreComponents do
  use Phoenix.Component

  alias Phoenix.LiveView.JS
-  import ArrowWeb.Gettext
+  use Gettext, backend: ArrowWeb.Gettext


https://hexdocs.pm/gettext/changelog.html#v0-26-0

Whoops · 2024-10-24T18:01:22Z

lib/arrow_web/controllers/shape_controller.ex

@@ -51,11 +51,6 @@ defmodule ArrowWeb.ShapeController do
        conn
        |> put_flash(:errors, reason)
        |> render(:new_bulk, errors: reason, shapes_upload: reset_upload)
-
-      error ->


Dialyzer flags this clause as unreachable, and I agree. parse_kml_from_file and shapes_from_kml will always return {:ok, _} or {:error, _}, and changeset will always return a changeset, so will always match.

Whoops · 2024-10-24T18:03:09Z

mix.exs

@@ -14,7 +14,7 @@ defmodule Arrow.MixProject do
      releases: releases(),
      dialyzer: [
        plt_add_apps: [:mix],
-        plt_add_deps: :transitive,
+        plt_add_deps: :app_tree,


https://hexdocs.pm/dialyxir/changelog.html#changed-3

Whoops · 2024-10-24T21:16:34Z

mix.exs

        flags: [
          :unmatched_returns
-        ],
-        ignore_warnings: ".dialyzer.ignore-warnings"


Dialyzer complained about could not read file stats ".dialyzer_ignore.exs": no such file or directory as long as this was present. I didn't figure out why, but we also aren't ignoring warnings (.dialyzer.ignore-warnings is blank) so I removed it.

Whoops · 2024-10-24T21:19:16Z

Dockerfile

@@ -39,6 +39,7 @@ COPY config/config.exs config/
 COPY config/prod.exs config/

 RUN mix deps.compile
+RUN mix sentry.package_source_code


https://hexdocs.pm/sentry/upgrade-10-x.html#what-do-i-have-to-do

meagharty · 2024-10-28T16:35:51Z

test/arrow_web/controllers/stop_controller_test.exs

@@ -40,7 +40,7 @@ defmodule ArrowWeb.StopControllerTest do
      conn = post(conn, ~p"/stops", stop: invalid_attrs)
      assert redirected_to(conn) == ~p"/stops/new"

-      assert get_flash(conn, :errors) ==
+      assert conn.assigns.flash["errors"] ==


Suggested change

assert conn.assigns.flash["errors"] ==

assert Phoenix.Flash.get(conn.assigns.flash, :errors) ==

meagharty · 2024-10-28T16:43:14Z

mix.exs

-      {:httpoison, "~> 1.6"},
-      {:ja_serializer, github: "mbta/ja_serializer", branch: "master"},
+      {:httpoison, "~> 2.2"},
+      {:ja_serializer, "~> 0.18.0"},


I'm in support of this change since our version hasn't been maintained.

Was this upgrade of ja_serializer required as part of upgrading the elixir version though?

Can we split this change into it's own separate PR? If we notice any unexpected changes (like with the gtfs_creator build when parsing API results, performance issues with endpoints, whatever), it'd be easier to isolate that way.

meagharty

🎉

meagharty · 2024-10-28T21:21:39Z

lib/arrow/disruption_revision.ex

@@ -285,4 +285,12 @@ defmodule Arrow.DisruptionRevision do
        changeset
    end
  end
+
+  defp date_range(start_date, end_date) do


I think the code below is correct but what you meant in this comment was start_date > end_date for step of -1 (so it enumerates backwards in time from start_date to end_date)

Whoops had a problem deploying to dev October 24, 2024 17:22 — with GitHub Actions Failure

Whoops temporarily deployed to dev October 24, 2024 17:26 — with GitHub Actions Inactive

Whoops commented Oct 24, 2024

View reviewed changes

Whoops temporarily deployed to dev October 24, 2024 18:03 — with GitHub Actions Inactive

Whoops temporarily deployed to dev October 24, 2024 18:26 — with GitHub Actions Inactive

Whoops temporarily deployed to dev October 24, 2024 18:58 — with GitHub Actions Inactive

Whoops force-pushed the wh-update-elixir branch from 6ab824d to 1356585 Compare October 24, 2024 19:03

Whoops marked this pull request as ready for review October 24, 2024 21:03

Whoops force-pushed the wh-update-elixir branch 2 times, most recently from e2dfd6a to 349fcdf Compare October 24, 2024 21:14

Whoops commented Oct 24, 2024

View reviewed changes

Whoops requested review from a team and meagharty and removed request for a team October 24, 2024 21:17

Whoops commented Oct 24, 2024

View reviewed changes

meagharty requested changes Oct 28, 2024

View reviewed changes

Whoops added 4 commits October 28, 2024 12:01

chore: bump elixir & erlang versions

ac50028

fix: resolve warning deprication messages coming from Arrow

3462458

fix: resolve sentry deprecations

a9dd673

fix: resolve wallaby deprecation warnings

c7577bd

Whoops force-pushed the wh-update-elixir branch from 349fcdf to 61d5a89 Compare October 28, 2024 18:09

Whoops added 3 commits October 28, 2024 12:11

fix: deprecation warnings in tests

ee9c11e

chore: minor dependency version bumps

5d9587c

chore: update mox

44eb88f

Whoops added 10 commits October 28, 2024 12:11

chore: update http_poison

65a2849

chore: update telemetry

73b4684

chore: update debian container

311bbd2

fix: use string instead of charlist

309ad7e

fix: address gettext deprecations

b6a7d46

fix: dialyzer deprecation

e56423e

fix: ignore .elixir_ls

18cde9e

fix: remove unecessary error clause

ee36164

fix: ssl_opts is deprecated

20c97fc

fix: using warning instead of warn on LoggerBackend

dbdc2cf

Whoops force-pushed the wh-update-elixir branch from 61d5a89 to dbdc2cf Compare October 28, 2024 18:11

Whoops requested a review from meagharty October 28, 2024 18:16

meagharty approved these changes Oct 28, 2024

View reviewed changes

Whoops merged commit 8c2acde into master Oct 29, 2024
28 checks passed

Whoops deleted the wh-update-elixir branch October 29, 2024 17:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🏹 Upgrade Elixir version #1024

🏹 Upgrade Elixir version #1024

Whoops commented Oct 24, 2024

Whoops Oct 24, 2024

Whoops Oct 24, 2024

meagharty Oct 28, 2024

Whoops Oct 24, 2024

meagharty Oct 28, 2024

Whoops Oct 28, 2024

Whoops Oct 24, 2024

Whoops Oct 24, 2024

Whoops Oct 24, 2024

Whoops Oct 24, 2024

Whoops Oct 24, 2024

Whoops Oct 24, 2024

meagharty Oct 28, 2024

meagharty Oct 28, 2024

meagharty left a comment

meagharty Oct 28, 2024

	assert conn.assigns.flash["errors"] ==
	assert Phoenix.Flash.get(conn.assigns.flash, :errors) ==

🏹 Upgrade Elixir version #1024

🏹 Upgrade Elixir version #1024

Conversation

Whoops commented Oct 24, 2024

Summary of changes

Reviewer Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meagharty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment