Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyzer to automatically build binaries using github actions #4

Open
nbanerje opened this issue Mar 10, 2022 · 1 comment
Open

Comments

@nbanerje
Copy link

Hi! I'm a Product Manager at Saleae and we’ve made improvements to our analyzer build process. Specifically, we cleaned up the build system, and switched to cmake, so there aren't multiple project files anymore. By implementing the changes outlined here you will be able to provide the community automatic builds in addition to a simplified build system. Let us know if you think you can make the changes or if you’d like us to make the changes for you.

Additionally, if you would like to update your analyzer so that results appear in Logic 2’s data table you can follow the steps outlined here. Note that if you upgrade your analyzer to FrameV2 it will not be backward compatible with Logic 1.

We really appreciate your time and effort! Please let us know if you have any feedback or questions. Thanks!

@ppannuto
Copy link
Member

Hi @nbanerje -- awesome set of updates! This analyzer is used, but it's pretty firmly in maintenance mode and not something that I would be readily able to update to the new build ecosystem or sink development time into until late summer at the earliest. That said, if you're willing to make the changes I would very happily merge them (including setting up actions to auto-push; that's a super cool idea). Thanks for reaching out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants