Skip to content

Commit

Permalink
boot: zephyr: Remove broken target config header feature
Browse files Browse the repository at this point in the history
Remove broken target config header feature.
This has been broken for more than 6 years, and seeing as nobody noticed
it should be ok to remove it.

Broken because if(EXISTS path-to-file-or-directory) uses relative path.
From cmake documentation:
"Behavior is well-defined only for explicit full paths".

Secondly ${BOARD}.h does not account for changes introduced in hwmv2
where BOARD_QUALIFIER maybe should be handled as well.

Also, who will put their board config files here?

Signed-off-by: Joakim Andersson <joerchan@gmail.com>
  • Loading branch information
joerchan authored and nordicjm committed Sep 27, 2024
1 parent f8d8004 commit f9fc591
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 41 deletions.
4 changes: 0 additions & 4 deletions boot/zephyr/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,7 @@ endif()

zephyr_library_include_directories(
include
targets
)
if(EXISTS targets/${BOARD}.h)
zephyr_library_compile_definitions(MCUBOOT_TARGET_CONFIG="${BOARD}.h")
endif()

# Zephyr port-specific sources.
zephyr_library_sources(
Expand Down
37 changes: 0 additions & 37 deletions boot/zephyr/targets/arduino_101.h

This file was deleted.

0 comments on commit f9fc591

Please sign in to comment.