boot: main: avoid unused build warning #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioalves
commented
Jul 1, 2024
|
@nordicjm @almir-okato PTAL. |
nordicjm
requested changes
Jul 8, 2024
sylvioalves
force-pushed
the
bugfix/unused
branch
from
8b74eb3
to
75a3d74
Compare
|
@nordicjm I inverted the call order instead of creating an additional #ifdef just because of a single variable. Let me know if it fits you. PTAL again. |
nordicjm
reviewed
Aug 20, 2024
In case ESP32 SoC is used, *start will get build warning as it is not used. Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
sylvioalves
force-pushed
the
bugfix/unused
branch
from
75a3d74
to
6387407
Compare
|
@nordicjm Ok, taking your suggestion and adding #ifdef around it. |
nordicjm
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case ESP32 SoC is used, *start will get
build warning as it is not used.