Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephyr/Kconfig.serial_recovery: limit Slot info command #2073

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nvlsianpu
Copy link
Collaborator

BOOT_SERIAL_IMG_GRP_SLOT_INFO should be not available for direct-xip and ram-load modes.

BOOT_SERIAL_IMG_GRP_SLOT_INFO should be not available for
direct-xip and ram-load modes.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu added a commit to nvlsianpu/fw-nrfconnect-mcuboot that referenced this pull request Sep 24, 2024
BOOT_SERIAL_IMG_GRP_SLOT_INFO should be not available for
direct-xip and ram-load modes.

Upstream PR: mcu-tools/mcuboot#2073

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu added a commit to nvlsianpu/fw-nrfconnect-mcuboot that referenced this pull request Sep 24, 2024
BOOT_SERIAL_IMG_GRP_SLOT_INFO should be not available for
direct-xip and ram-load modes.

Upstream PR: mcu-tools/mcuboot#2073

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
@@ -204,7 +204,8 @@ config BOOT_SERIAL_IMG_GRP_IMAGE_STATE

config BOOT_SERIAL_IMG_GRP_SLOT_INFO
bool "Slot info"
default y if UPDATEABLE_IMAGE_NUMBER > 1
depends on !BOOT_DIRECT_XIP && !BOOT_RAM_LOAD
default y if (UPDATEABLE_IMAGE_NUMBER > 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove brackets so it matches the upstream data without adding a new change

bjarki-andreasen pushed a commit to bjarki-andreasen/sdk-mcuboot that referenced this pull request Sep 24, 2024
BOOT_SERIAL_IMG_GRP_SLOT_INFO should be not available for
direct-xip and ram-load modes.

Upstream PR: mcu-tools/mcuboot#2073

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper fix: #2075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants