Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Step-Sequencer Noise Duration 0 causes uncaught DOM exception #112

Closed
grhhhh opened this issue Oct 2, 2023 · 1 comment · Fixed by #113
Closed

Bug: Step-Sequencer Noise Duration 0 causes uncaught DOM exception #112

grhhhh opened this issue Oct 2, 2023 · 1 comment · Fixed by #113
Labels
bug Indicates an unexpected problem or unintended behavior. effort: small Task is a small effort. ex: step-sequencer has PR

Comments

@grhhhh
Copy link
Contributor

grhhhh commented Oct 2, 2023

What information was incorrect, unhelpful, or incomplete?

TLDR: Noise Dur slider positions left of the midpoint break the step sequencer app

Noise Dur slider positions left of the midpoint cause the noiseBuffer AudioBuffer to be initialized with a length of 0 resulting in the following error:

Uncaught DOMException: Failed to construct 'AudioBuffer': The number of frames provided (0) is less than or equal to the minimum bound (0).

What did you expect to see?

Non-breaking functionality of the Noise Dur slider in the Step Sequencer

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response
@grhhhh grhhhh added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

It looks like this is your first issue. Welcome! 👋
One of the project maintainers will be with you as soon as possible. We
appreciate your patience. To safeguard the health of the project, please
take a moment to read our code of conduct.

@grhhhh grhhhh mentioned this issue Oct 2, 2023
Merged
@caugner caugner added ex: step-sequencer bug Indicates an unexpected problem or unintended behavior. has PR effort: small Task is a small effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 16, 2023
bsmth pushed a commit that referenced this issue Jan 25, 2024
@grhhhh @teoli2003 @caugner
Issue #112 Fix: Updates Noise Dur Slider value assignment (#113)
f366a17 
* Updates slider min, max and step values. Removes parseInt.

* Update step-sequencer/index.html

Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>

---------

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior. effort: small Task is a small effort. ex: step-sequencer has PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #112 Fix: Updates Noise Dur Slider value assignment grhhhh/webaudio-examples
2 participants
@caugner @grhhhh