Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use parseFloat for sliders, typos #122

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix: Use parseFloat for sliders, typos #122

merged 2 commits into from
Mar 20, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 25, 2024 •
edited
Loading

Follow-up from #113, I think we should be using parseFloat for the rest of the values here. Some typo fixes in parallel

edit:

I think this might fix #118

@bsmth bsmth requested a review from caugner January 25, 2024 10:24
ManuLintz
ManuLintz suggested changes Jan 25, 2024
View reviewed changes
Copy link

@ManuLintz ManuLintz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, I'm happy to see that this repo still gets some love :)
I'm working on another PR on the same file so I checked yours.
I just wanted to point out that parseFloat takes only one argument

step-sequencer/index.html Outdated Show resolved Hide resolved
step-sequencer/index.html Outdated Show resolved Hide resolved
@ManuLintz ManuLintz mentioned this pull request Jan 25, 2024
Draft
ManuLintz
ManuLintz approved these changes Jan 25, 2024
View reviewed changes
Copy link

@ManuLintz ManuLintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving to let you (and the approving reviewer) know that I'm happy with the changes you made regarding my previous comment

@dylanwright dylanwright mentioned this pull request Feb 21, 2024
Closed
dipikabh
dipikabh approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🙌

@dipikabh dipikabh merged commit b57bacf into mdn:main Mar 20, 2024
2 checks passed
@bsmth bsmth deleted the step-sequencer-floats branch March 20, 2024 16:47
@bsmth
Copy link
Member Author

bsmth commented Mar 20, 2024

Thanks, both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuLintz ManuLintz ManuLintz approved these changes

@dipikabh dipikabh dipikabh approved these changes

@caugner caugner Awaiting requested review from caugner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[step-sequencer] The slider input to set the DTMF rate is not working as expected
3 participants
@bsmth @dipikabh @ManuLintz