Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] use PRs for new features #746

Open
thewh1teagle opened this issue Nov 23, 2024 · 2 comments
Open

[question] use PRs for new features #746

thewh1teagle opened this issue Nov 23, 2024 · 2 comments
Labels
question Further information is requested

Comments

@thewh1teagle
Copy link

thewh1teagle commented Nov 23, 2024

Please use PRs for new commits in main instead of pushing directly to main
And squash the commits from the PR so it won't merge multiple commits from the PR but instead single commit

context
It's hard to keep track of the new changes in in screenpipe (In PRs we should get notification) and also the main branch history has too many irrelevant commits

Personally I also like to push directly to main :) but I big projects it's worth not do that at all and in worst case just create PRs such as patch-1 or patch-2 etc.

btw with github cli it's easy as

gh pr create
gh pr merge
@thewh1teagle thewh1teagle added the question Further information is requested label Nov 23, 2024
Copy link

linear bot commented Nov 23, 2024

@louis030195
Copy link
Collaborator

thx, will try to be more careful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants