From 6cc2a89e2b2982a7185e289a9ea8c8f2da969816 Mon Sep 17 00:00:00 2001
From: Mehdi <9340937+meduzen@users.noreply.github.com>
Date: Sat, 5 Aug 2023 23:53:17 +0200
Subject: [PATCH] Save some bytes and pre-release 1.3.2

Also:
* test precision in `DateTime.to`;
* update types (unchanged API);
* update documentation and changelog.
---
 CHANGELOG.md              |  7 +++++++
 README.md                 | 25 +++++++++++++------------
 package.json              |  2 +-
 pnpm-lock.yaml            | 38 +++++++++++++++++++-------------------
 src/datetime-class.js     |  8 ++------
 src/utils/date.js         | 12 ++++++++----
 tests/index.test.js       |  9 +++++----
 types/datetime-class.d.ts |  4 ++--
 8 files changed, 57 insertions(+), 48 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f5bddca..0542ed9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,13 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 Compare with [last published version](https://github.com/meduzen/datetime-attribute/compare/1.3.1...main).
 
+### Improved
+
+- Shorten `daysBetween()` and `DateTime` footprint by a couple of bytes.
+
+> **Warning**\
+> If not transpiled, `DateTime` now requires support for [`class` fields](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields#browser_compatibility) (Safari 14.0).
+
 ### Under the hood
 
 - Replace NPM by pnpm
diff --git a/README.md b/README.md
index 191fa1c..057b1f5 100644
--- a/README.md
+++ b/README.md
@@ -3,16 +3,16 @@
 Get a [`datetime` attribute](https://developer.mozilla.org/en-US/docs/Web/API/HTMLTimeElement/datetime) for HTML `<time>` (and [other elements](#not-only-in-time)).
 
 It covers the [whole WHATWG specification](https://html.spec.whatwg.org/multipage/text-level-semantics.html#attr-time-datetime) in 4 functions:
-- [**`datetime()`**](#expressing-moments-with-datetime) for a specific moment ([666 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{datetime}]&bundle));
-- [**`datetimeTz()`**](#adding-a-timezone-offset-to-a-moment-with-datetimetz) for a specific moment in a given timezone ([936 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{datetimeTz}]&bundle));
-- [**`duration()`**](#expressing-durations-with-duration) for a duration ([339 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{duration}]&bundle));
-- [**`tzOffset()`**](#expressing-timezone-offsets-with-tzoffset) for a timezone offset ([340 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{tzOffset}]&bundle)).
+- [**`datetime()`**](#expressing-moments-with-datetime) for a specific moment ([645 B compressed](https://bundlejs.com/?q=datetime-attribute&treeshake=[{datetime}]&bundle));
+- [**`datetimeTz()`**](#adding-a-timezone-offset-to-a-moment-with-datetimetz) for a specific moment in a given timezone ([942 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{datetimeTz}]&bundle));
+- [**`duration()`**](#expressing-durations-with-duration) for a duration ([307 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{duration}]&bundle));
+- [**`tzOffset()`**](#expressing-timezone-offsets-with-tzoffset) for a timezone offset ([388 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{tzOffset}]&bundle)).
 
-Additionally, a [`DateTime` class](#the-datetime-class) ([741 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{DateTime}]&bundle)) and some [other functions](#other-functions) are provided.
+Additionally, a [`DateTime` class](#the-datetime-class) ([721 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{DateTime}]&bundle)) and some [other functions](#other-functions) are provided.
 
 [![Node.js CI](https://github.com/meduzen/datetime-attribute/actions/workflows/node.js.yml/badge.svg)](https://github.com/meduzen/datetime-attribute/actions/workflows/node.js.yml)
 
-The package is lightweight ([~ 1.39 KB compressed](https://bundlejs.com/?q=datetime-attribute&bundle) for `import *`), **tree-shakeable**, **typed** and tested.
+The package is lightweight ([~ 1.42 KB compressed](https://bundlejs.com/?q=datetime-attribute&bundle) for `import *`), tree-shakeable, typed and tested.
 
 ## Table of contents
 
@@ -419,6 +419,8 @@ daysBetween(january1st, january11th) // 10
 daysBetween(january19th, january11th) // -8
 ```
 
+([134 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{daysBetween}]&bundle))
+
 ### `weekNumber()`
 
 Get the week number as [defined by the WHATWG](https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#weeks), following the ISO-8601 specs:
@@ -440,15 +442,18 @@ weekNumber(january1st) // 53: it’s a Friday!
 weekNumber(january11th) // 2
 ```
 
+([201 B](https://bundlejs.com/?q=datetime-attribute&treeshake=[{weekNumber}]&bundle))
+
 ## Changelog
 
 See [CHANGELOG.md](https://github.com/meduzen/datetime-attribute/blob/main/CHANGELOG.md) or the [releases](https://github.com/meduzen/datetime-attribute/releases).
 
 ## Browser and tooling support
 
-`datetime-attribute` is provided for [modern browsers usage](https://github.com/meduzen/datetime-attribute/blob/main/browserslist) with standard JavaScript syntax:
+`datetime-attribute` is provided [as module](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules#browser_compatibility) for [modern browsers usage](https://github.com/meduzen/datetime-attribute/blob/main/browserslist) with standard JavaScript syntax:
 - it is up to you to transpile it for legacy browsers;
-- you can’t import it using `require('datetime-attribute')`.
+- you can’t import it using `require('datetime-attribute')`;
+- if you don’t transpile it, `DateTime` requires support for [`class` fields](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields#browser_compatibility) (Safari 14.0) starting `v1.32.0`.
 
 [Read more about ESModules](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c).
 
@@ -472,7 +477,3 @@ See the [contributing guidelines](https://github.com/meduzen/datetime-attribute/
 ## License
 
 The _datetime-attribute_ package is open-sourced software licensed under the [DWTFYWTPL](https://github.com/meduzen/datetime-attribute/blob/main/LICENSE).
-
-## 
-
-[![Verified on Openbase](https://badges.openbase.com/js/verified/datetime-attribute.svg?token=ngHvoLLDN27g9x7qUc+Ihp2QJNmvGWNxVkuA/5ldiKI=)](https://openbase.com/js/datetime-attribute?utm_source=embedded&amp;utm_medium=badge&amp;utm_campaign=rate-badge)
diff --git a/package.json b/package.json
index ab89586..5dcf0ab 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "datetime-attribute",
-  "version": "1.3.1",
+  "version": "1.3.2-0",
   "description": "Generate datetime attributes for the <time> HTML element, following WHATWG and ISO8601 specs.",
   "type": "module",
   "sideEffects": false,
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index dc96a6d..98d7a0e 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -431,8 +431,8 @@ packages:
     resolution: {integrity: sha512-jhuKLIRrhvCPLqwPcx6INqmKeiA5EWrsCOPhrlFSrbrmU4ZMPjj5Ul/oLCMDO98XRUIwVm78xICz4EPCektzeQ==}
     dev: true
 
-  /@types/node@20.4.6:
-    resolution: {integrity: sha512-q0RkvNgMweWWIvSMDiXhflGUKMdIxBo2M2tYM/0kEGDueQByFzK4KZAgu5YHGFNxziTlppNpTIBcqHQAxlfHdA==}
+  /@types/node@20.4.8:
+    resolution: {integrity: sha512-0mHckf6D2DiIAzh8fM8f3HQCvMKDpK94YQ0DSVkfWTG9BZleYIWudw9cJxX8oCk9bM+vAkDyujDV6dmKHbvQpg==}
     dev: true
 
   /@types/normalize-package-data@2.4.1:
@@ -1142,8 +1142,8 @@ packages:
     resolution: {integrity: sha512-zz06S8t0ozoDXMG+ube26zeCTNXcKIPJZJi8hBrF4idCLms4CG9QtK7qBl1boi5ODzFpjswb5JPmHCbMpjaYzg==}
     dev: true
 
-  /is-core-module@2.12.1:
-    resolution: {integrity: sha512-Q4ZuBAe2FUsKtyQJoQHlvP8OvBERxO3jEmy1I7hcRXcJBGGHFh/aJBswbXuS9sgrDH2QUO8ilkwNPHvHMd8clg==}
+  /is-core-module@2.13.0:
+    resolution: {integrity: sha512-Z7dk6Qo8pOCp3l4tsX2C5ZVas4V+UxwQodwZhLopL91TX8UyyHEXafPcyoeeWuLrwzHcr3igO78wNLwHJHsMCQ==}
     dependencies:
       has: 1.0.3
     dev: true
@@ -1432,7 +1432,7 @@ packages:
     resolution: {integrity: sha512-/5CMN3T0R4XTj4DcGaexo+roZSdSFW/0AOOTROrjxzCG1wrWXEsGbRKevjlIL+ZDE4sZlJr5ED4YW0yqmkK+eA==}
     dependencies:
       hosted-git-info: 2.8.9
-      resolve: 1.22.2
+      resolve: 1.22.4
       semver: 5.7.2
       validate-npm-package-license: 3.0.4
     dev: true
@@ -1442,7 +1442,7 @@ packages:
     engines: {node: '>=10'}
     dependencies:
       hosted-git-info: 4.1.0
-      is-core-module: 2.12.1
+      is-core-module: 2.13.0
       semver: 7.5.4
       validate-npm-package-license: 3.0.4
     dev: true
@@ -1651,11 +1651,11 @@ packages:
     engines: {node: '>=4'}
     dev: true
 
-  /resolve@1.22.2:
-    resolution: {integrity: sha512-Sb+mjNHOULsBv818T40qSPeRiuWLyaGMa5ewydRLFimneixmVy2zdivRl+AF6jaYPC8ERxGDmFSiqui6SfPd+g==}
+  /resolve@1.22.4:
+    resolution: {integrity: sha512-PXNdCiPqDqeUou+w1C2eTQbNfxKSuMxqTCuvlmmMsk1NWHL5fRrhY6Pl0qEYYc6+QqGClco1Qj8XnjPego4wfg==}
     hasBin: true
     dependencies:
-      is-core-module: 2.12.1
+      is-core-module: 2.13.0
       path-parse: 1.0.7
       supports-preserve-symlinks-flag: 1.0.0
     dev: true
@@ -1672,8 +1672,8 @@ packages:
       glob: 7.2.3
     dev: true
 
-  /rollup@3.27.1:
-    resolution: {integrity: sha512-tXNDFwOkN6C2w5Blj1g6ForKeFw6c1mDu5jxoeDO3/pmYjgt+8yvIFjKzH5FQUq70OKZBkOt0zzv0THXL7vwzQ==}
+  /rollup@3.27.2:
+    resolution: {integrity: sha512-YGwmHf7h2oUHkVBT248x0yt6vZkYQ3/rvE5iQuVBh3WO8GcJ6BNeOkpoX1yMHIiBm18EMLjBPIoUDkhgnyxGOQ==}
     engines: {node: '>=14.18.0', npm: '>=8.0.0'}
     hasBin: true
     optionalDependencies:
@@ -1957,7 +1957,7 @@ packages:
       spdx-expression-parse: 3.0.1
     dev: true
 
-  /vite-node@0.34.1(@types/node@20.4.6):
+  /vite-node@0.34.1(@types/node@20.4.8):
     resolution: {integrity: sha512-odAZAL9xFMuAg8aWd7nSPT+hU8u2r9gU3LRm9QKjxBEF2rRdWpMuqkrkjvyVQEdNFiBctqr2Gg4uJYizm5Le6w==}
     engines: {node: '>=v14.18.0'}
     hasBin: true
@@ -1967,7 +1967,7 @@ packages:
       mlly: 1.4.0
       pathe: 1.1.1
       picocolors: 1.0.0
-      vite: 4.4.8(@types/node@20.4.6)
+      vite: 4.4.8(@types/node@20.4.8)
     transitivePeerDependencies:
       - '@types/node'
       - less
@@ -1979,7 +1979,7 @@ packages:
       - terser
     dev: true
 
-  /vite@4.4.8(@types/node@20.4.6):
+  /vite@4.4.8(@types/node@20.4.8):
     resolution: {integrity: sha512-LONawOUUjxQridNWGQlNizfKH89qPigK36XhMI7COMGztz8KNY0JHim7/xDd71CZwGT4HtSRgI7Hy+RlhG0Gvg==}
     engines: {node: ^14.18.0 || >=16.0.0}
     hasBin: true
@@ -2007,10 +2007,10 @@ packages:
       terser:
         optional: true
     dependencies:
-      '@types/node': 20.4.6
+      '@types/node': 20.4.8
       esbuild: 0.18.17
       postcss: 8.4.27
-      rollup: 3.27.1
+      rollup: 3.27.2
     optionalDependencies:
       fsevents: 2.3.2
     dev: true
@@ -2048,7 +2048,7 @@ packages:
     dependencies:
       '@types/chai': 4.3.5
       '@types/chai-subset': 1.3.3
-      '@types/node': 20.4.6
+      '@types/node': 20.4.8
       '@vitest/expect': 0.34.1
       '@vitest/runner': 0.34.1
       '@vitest/snapshot': 0.34.1
@@ -2068,8 +2068,8 @@ packages:
       strip-literal: 1.3.0
       tinybench: 2.5.0
       tinypool: 0.7.0
-      vite: 4.4.8(@types/node@20.4.6)
-      vite-node: 0.34.1(@types/node@20.4.6)
+      vite: 4.4.8(@types/node@20.4.8)
+      vite-node: 0.34.1(@types/node@20.4.8)
       why-is-node-running: 2.2.2
     transitivePeerDependencies:
       - less
diff --git a/src/datetime-class.js b/src/datetime-class.js
index 7feadba..539fabc 100644
--- a/src/datetime-class.js
+++ b/src/datetime-class.js
@@ -13,9 +13,7 @@ export class DateTime extends Date {
    *
    * @returns {number}
    */
-  getWeek() {
-    return weekNumber(this)
-  }
+  getWeek = () => weekNumber(this)
 
   /**
    * Set the week number.
@@ -34,7 +32,5 @@ export class DateTime extends Date {
    * @param {import('./datetime.js').Precision} precision
    * @returns {string}
    */
-  to(precision) {
-    return datetime(this, precision)
-  }
+  to = precision => datetime(this, precision)
 }
diff --git a/src/utils/date.js b/src/utils/date.js
index 33619d5..53c6871 100644
--- a/src/utils/date.js
+++ b/src/utils/date.js
@@ -8,12 +8,16 @@ import { MILLISECONDS_PER_DAY } from './const.js'
  * @returns {number}
  */
 export function daysBetween(date, furtherDate) {
-  date = new Date(date.getFullYear(), date.getMonth(), date.getDate())
-  furtherDate = new Date(furtherDate.getFullYear(), furtherDate.getMonth(), furtherDate.getDate())
 
-  const diffInDays = (furtherDate - date) / MILLISECONDS_PER_DAY
+  // discard time of day
+  [date, furtherDate] = [date, furtherDate].map(d => new Date(d.getFullYear(), d.getMonth(), d.getDate()))
 
-  return Math.ceil(diffInDays)
+  /**
+   * The commented code below could be accurate if we cared about time of day.
+   */
+  // return Math.ceil((furtherDate - date) / MILLISECONDS_PER_DAY)
+
+  return (furtherDate - date) / MILLISECONDS_PER_DAY
 }
 
 /**
diff --git a/tests/index.test.js b/tests/index.test.js
index 7db33de..6a68711 100644
--- a/tests/index.test.js
+++ b/tests/index.test.js
@@ -247,16 +247,17 @@ describe('daysBetween', () => {
 })
 
 const summer = new DateTime(2021, 5, 21)
-const oneWeekAfterSummer = new DateTime(2021, 5, 28)
+const twoWeeksAfterSummer = new DateTime(2021, 6, 5)
 
 describe('DateTime class', () => {
   test('extends Date', () => expect(summer).toBeInstanceOf(Date))
   test('.getWeek', () => expect(summer.getWeek()).toBe(25))
-  test('.setWeek', () => expect(summer.setWeek(26)).toBe(oneWeekAfterSummer.getTime()))
-  test(".to('day')", () => expect(summer.to('day')).toBe('2021-06-28'))
+  test(".to('day')", () => expect(summer.to('day')).toBe('2021-06-21'))
+  test('.setWeek', () => expect(summer.setWeek(27)).toBe(twoWeeksAfterSummer.getTime()))
+  test(".to('month')", () => expect(twoWeeksAfterSummer.to('month')).toBe('2021-07'))
   test('weeks is changed when day changes', () => {
     summer.setDate(summer.getDate() + 14)
-    return expect(summer.getWeek()).toBe(28)
+    return expect(summer.getWeek()).toBe(29)
   })
 })
 
diff --git a/types/datetime-class.d.ts b/types/datetime-class.d.ts
index 238204d..3ed7855 100644
--- a/types/datetime-class.d.ts
+++ b/types/datetime-class.d.ts
@@ -9,7 +9,7 @@ export class DateTime extends Date {
      *
      * @returns {number}
      */
-    getWeek(): number;
+    getWeek: () => number;
     /**
      * Set the week number.
      *
@@ -23,5 +23,5 @@ export class DateTime extends Date {
      * @param {import('./datetime.js').Precision} precision
      * @returns {string}
      */
-    to(precision: import('./datetime.js').Precision): string;
+    to: (precision: import('./datetime.js').Precision) => string;
 }