Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use iconPaddingStart and iconPaddingEnd #97

Open
shahimclt opened this issue Sep 12, 2017 · 1 comment
Open

use iconPaddingStart and iconPaddingEnd #97

shahimclt opened this issue Sep 12, 2017 · 1 comment

Comments

@shahimclt
Copy link

please consider adding support for RTL layouts. Now, we have to add both right and left padding to preserve spacing in both LTR and RTL layouts, which in turn throws off the center alignment a bit.

@shahimclt
Copy link
Author

For anyone wondering the same thing, here is a temporary fix:

<mehdi.sakout.fancybuttons.FancyButton
        android:paddingEnd="@dimen/activity_horizontal_margin"
        android:paddingStart="0"
        fancy:fb_iconPaddingLeft="@dimen/activity_horizontal_margin"
        fancy:fb_iconPaddingRight="@dimen/activity_horizontal_margin"
        />

Just add an android:paddingEnd to balance the icon's padding in the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants