feat: add timelock-id in notifications #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapati23
reviewed
Aug 5, 2024
nvtaveras
changed the title
nvtaveras
commented
Aug 5, 2024
src/index.ts
Outdated
Comment on lines
39
to
40
| // eslint-disable-next-line | ||
| parsedEvent.timeLockId!, |
There was a problem hiding this comment.
this would need a bit of refactoring to remove the eslint warning so decided not to do this at the moment
nvtaveras
changed the title
that's how openzeppelin spells it everywhere :)
chapati23
approved these changes
Aug 6, 2024
chapati23
added a commit
that referenced
this pull request
Aug 6, 2024
This adds the timelock ID to the discord/telegram notification messages so that it can be used by members of the watchdog group to veto a proposal if needed. Discord <img width="543" alt="Screenshot 2024-08-05 at 14 48 03" src="https://github.com/user-attachments/assets/0b625587-b62a-48ec-94f4-51e35be71f7d"> Telegram  --------- Co-authored-by: Philip Paetz <philip.paetz@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the timelock ID to the discord/telegram notification messages so that it can be used by members of the watchdog group to veto a proposal if needed.
Discord
Telegram
