-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add timelock-id in notifications #13
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0e8e794
feat: add get-time-lock-id script
nvtaveras f5df43a
chore: linter
nvtaveras 3299ad8
Merge branch 'main' into feat/timeLockIdhelper
nvtaveras fda4892
chore: remove ts-node and script from package.json
nvtaveras a3e6d1c
feat: include time-lock-id in notification msg
nvtaveras 6156e39
fix: removed eslint-disable comment via assert statement
chapati23 8bfd892
chore: "Time Lock" => "Timelock"
chapati23 929b275
chore: add timelock operation id explainer
chapati23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { encodeAbiParameters, parseAbiParameters, keccak256 } from "viem"; | ||
|
||
import { ProposalCreatedEvent } from "../types"; | ||
|
||
export default function getProposalTimeLockId( | ||
event: ProposalCreatedEvent, | ||
): string { | ||
const { targets, values, calldatas, description } = event.args; | ||
const descriptionHash = keccak256(Buffer.from(description)); | ||
|
||
return keccak256( | ||
encodeAbiParameters( | ||
parseAbiParameters("address[], uint256[], bytes[], uint256, bytes32"), | ||
// _timelockIds[proposalId] = _timelock.hashOperationBatch(targets, values, calldatas, 0, descriptionHash); | ||
[targets, values, calldatas, 0n, descriptionHash], | ||
), | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would need a bit of refactoring to remove the eslint warning so decided not to do this at the moment