Add request signature validation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can't really test it until an actual proposal comes in, so we'll test this out in prod with the monitoring events from sorted oracles once that's ready
chapati23
force-pushed
the
feat/add-request-signature-validation
branch
from
2640b6e to
447baf6
Compare
|
Updated to include X-AUTH-Token header for internal testing request. Deployed + tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1 and #2 being merged first.
This adds a validation function to check if the caller of the cloud function is actually quick alerts following this: https://www.quicknode.com/docs/quickalerts/quickalerts-destinations/webhooks/webhook-signature
I left it outcommented in the main function for now because I couldn't test it with a real payload. I think it would be easiest to try this out for the monitoring events from sorted oracles because those come in frequently.