New Detection Sensor module for messaging the mesh on detected state changes #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
requested review from
caveman99,
garthvh,
jp-bennett,
code8buster,
ajmcquilkin,
andrekir,
mverch67 and
GUVWAF
mverch67
reviewed
Aug 13, 2023
thebentern
changed the title
code8buster
reviewed
Aug 13, 2023
code8buster
reviewed
Aug 13, 2023
code8buster
approved these changes
Aug 14, 2023
caveman99
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come to the realization that the remote hardware module is just not user friendly at all, and I don't believe it ever will be. This is my solution for the increasing number of folks wanting a simple way to setup PIR motions sensors, reed switches, rain sensors etc that have simple on/off states. This will allow a user to assign a friendly name and gpio pin to monitor for the state change message. I also think, like most modules we can auto-detect a small curated list of i2c based sensors like RAK's human presence radar sensor for instance and utilize those automatically as well.