rewriter: allow setting values regardless of the previous type #12782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alterations to kwargs come in two flavors:
Only for the second flavor do we care about the type of any existing value.
This is a minor rewrite of the rewriter. When merged, #12277 will need to be rebased.
Changes:
set_value
method.new_node
andsupported_nodes
methods of the type modification classes are now classmethods.new_node
method of the type modification classes is now public and can take an initial value.Conceptually, the mutability of kwargs now follows Python variable assignment. You don't change a value by reassigning to a variable name. Instead, this replaces the old value.
When merged, it will be possible to do
meson rewrite kwargs set project '/' version '1.0.0'
also with a build file likewhich makes the technique suggested in #688 (comment) possible.