-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backends: restore shlex quoting of MESONINTROSPECT #12807
backends: restore shlex quoting of MESONINTROSPECT #12807
Conversation
The |
It's really just a reimplementation of python 3.8's |
We can maybe do a bit better here, because crucially this style will be easy to use from Python as well (not just from a Unix shell). That makes it sensible for use on Windows too (e.g. this whole |
The type of quoting was changed in 522392e to one that is suitable for use with cmd.exe on Windows. However, the documentation states that the type of quoting in MESONINTROSPECT is compatible with shlex.split() and elsewhere in the code, the same variable is still quoted with shlex.quote(). As mostly identified in #12148, there are a few choices: 1. Use shlex.quote() consistently and support Python but not cmd.exe. 2. Use join_args and support cmd.exe but not Python. 3. Use join_args and support splitting through the mesonbuild Python library. This commit implements the first option and reverts part of 522392e. Regression testing is implemented in #12115. Fixes #12148
We need meson v1.4.0 to fix MESONINTROSPECT quoting on Windows: mesonbuild/meson#12807 Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
We need meson v1.4.0 to fix MESONINTROSPECT quoting on Windows: mesonbuild/meson#12807 Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
We need meson v1.4.0 to fix MESONINTROSPECT quoting on Windows: mesonbuild/meson#12807 Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
We need meson v1.4.0 to fix MESONINTROSPECT quoting on Windows: mesonbuild/meson#12807 Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> Message-Id: <20240327-meson-v3-1-7e6cdef1be8a@daynix.com>
The type of quoting was changed in 522392e to one that is suitable for use with
cmd.exe
on Windows. However, the documentation states that the type of quoting inMESONINTROSPECT
is compatible withshlex.split()
and elsewhere in the code, the same variable is still quoted withshlex.quote()
. As mostly identified in #12148, there are a few choices:shlex.quote()
consistently and support Python but notcmd.exe
.join_args
and supportcmd.exe
but not Python.join_args
and support splitting through themesonbuild
Python library.This commit implements the first option and reverts part of 522392e.
Regression testing is implemented in #12115.
Fixes #12148