Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backends: restore shlex quoting of MESONINTROSPECT #12807

Merged
merged 1 commit into from
Feb 11, 2024
Merged

backends: restore shlex quoting of MESONINTROSPECT #12807

merged 1 commit into from
Feb 11, 2024

Commits on Feb 10, 2024

  1. backends: restore shlex quoting of MESONINTROSPECT

    The type of quoting was changed in 522392e to one that is suitable for
    use with cmd.exe on Windows. However, the documentation states that the
    type of quoting in MESONINTROSPECT is compatible with shlex.split() and
    elsewhere in the code, the same variable is still quoted with
    shlex.quote(). As mostly identified in #12148, there are a few choices:
    1. Use shlex.quote() consistently and support Python but not cmd.exe.
    2. Use join_args and support cmd.exe but not Python.
    3. Use join_args and support splitting through the mesonbuild Python library.
    
    This commit implements the first option and reverts part of 522392e.
    
    Regression testing is implemented in #12115.
    
    Fixes #12148
    joukewitteveen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    9f79e86 View commit details
    Browse the repository at this point in the history