Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_single_test.py: skip setup_symlinks() call on Windows #13928

Merged
merged 1 commit into from
Nov 20, 2024
Merged

run_single_test.py: skip setup_symlinks() call on Windows #13928

merged 1 commit into from
Nov 20, 2024

Conversation

lb90
Copy link
Contributor

@lb90 lb90 commented Nov 19, 2024

This fixed run_single_test.py on my local development environment (base on MSYS2)

@lb90 lb90 requested a review from jpakkane as a code owner November 19, 2024 16:32
eli-schwartz
eli-schwartz requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is the wrong change. Notice how in run_project_tests.py, we run both scan_test_data_symlinks() and setup_symlinks(), only under !Windows. But in run_single_test.py, we run the former under !Windows, and unconditionally run the latter.

@lb90
Copy link
Contributor Author

lb90 commented Nov 20, 2024

Ah, indeed! Now changed

@lb90 lb90 changed the title run_project_tests.py: check if symlink objects are none run_single_test.py: skip setup_symlinks() call on Windows Nov 20, 2024
@eli-schwartz eli-schwartz merged commit 69af44d into mesonbuild:master Nov 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz requested changes

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lb90 @eli-schwartz