-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrapdb server static v1 api mirror and nginx config update #1772
Open
tp-m
wants to merge
1
commit into
mesonbuild:master
Choose a base branch
from
tp-m:nginx-v1-mirror
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−13
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's no longer needed, just remove it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OTOH, why not just use that redirect? Files are already hosted on github, we don't need another static mirror, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my previous comment, if you want to make sure the files are all there including the old sqlite things I'm all for it, I'm just not planning to do that work, and I also suspect there might be some discussions otherwise surely you'd have just done it back when you added the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should break things is what I'm saying, so if you want to enable the redirect make sure it won't break anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this test script inside wrapdb-v1-api-mirror repo:
Missing URLs are:
https://github.com/mesonbuild/wrapdb/releases/download/libjpeg_9c-4/libjpeg_9c-4_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/libjpeg_9c-2/libjpeg_9c-2_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/libjpeg_9c-3/libjpeg_9c-3_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/libjpeg_9c-1/libjpeg_9c-1_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/libjpeg_9a-4/libjpeg_9a-4_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/libjpeg_9a-2/libjpeg_9a-2_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/libjpeg_9a-5/libjpeg_9a-5_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3310100-1/sqlite_3310100-1_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3320300-4/sqlite_3320300-4_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3320300-3/sqlite_3320300-3_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3320300-5/sqlite_3320300-5_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3250100-2/sqlite_3250100-2_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3250100-1/sqlite_3250100-1_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3230100-1/sqlite_3230100-1_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3080802-4/sqlite_3080802-4_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3080802-2/sqlite_3080802-2_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3080802-5/sqlite_3080802-5_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3140200-2/sqlite_3140200-2_patch.zip
https://github.com/mesonbuild/wrapdb/releases/download/sqlite_3140200-1/sqlite_3140200-1_patch.zip
IMHO it's fine to break queries and download of wraps, we just need to keep patch zips. Those 2 deps are trivial to update to v2, I don't think it's a big deal to break them, it's been deprecated for years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to break it, break it, just leave me out of it please.
I don't think we should break it if there's no need and there isn't really any need since it work just fine as it is now.
Just leave the v1 alone as-is I'd say. You're now breaking something that works for no good reason other than to make the config a bit tidier.
libjpeg and sqlite are common wraps and breaking wrapdb stuff even if old will leave a bad taste imho.
Anyway, this ticket is a docs update updating the nginx config to the status quo.
Perhaps other changes you want to make should be tracked separately 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re. "trivial to update" that's beside the point because people will be consuming third party source repositories/branches/tags that they can't easily update without switching to their own modified copies or overwriting the checkouts manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now uploaded missing assets, the redirect URL should be enough.