Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct tag #170

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Correct tag #170

merged 1 commit into from
Jun 11, 2024

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Jun 7, 2024

See #169.

@dr0i dr0i requested a review from Phu2 June 7, 2024 08:25
@dr0i dr0i assigned Phu2 Jun 7, 2024
@Phu2
Copy link
Contributor

Phu2 commented Jun 7, 2024

I am not sure about the failing clojure tests. Please have a look, @dr0i

@Phu2 Phu2 assigned dr0i and unassigned Phu2 Jun 7, 2024
@dr0i
Copy link
Member Author

dr0i commented Jun 7, 2024

Obscure - tests are failing by changing the README?
Seems to be failing http tests - i.e. "live" tests of data that can be changed or not available.
I would say we ignore them for now?
In an ideal world we would mock a webserver and test against that, as we do e.g. here https://github.com/hbz/lobid-resources/blob/3619c74e625b1593e9c8528c294e15d6b37417fc/web/test/tests/IntegrationTests.java#L52.

@fsteeg
Copy link
Member

fsteeg commented Jun 7, 2024

The tests run all example workflows, so it seems since the last run two examples no longer work. We should probably fix them (or remove them if not fixable). Looking at the log (searching Testing example) it seems to be these two: Flux_Commands/filter-records-by-path, Flux_Commands/extract-element.

First one is actually failing:
https://metafacture.org/playground/?example=filter-records-by-path

The latter seems to work, maybe it was a temporary issue:
https://metafacture.org/playground/?example=extract-element

@dr0i
Copy link
Member Author

dr0i commented Jun 7, 2024

Both tests ran in the all preceeding commits OK. The problem is the http "live" test data:

curl https://kalliope-verbund.info/sru?version=1.2&operation=searchRetrieve&query=ead.repository.isil=DE-B1575&recordSchema=mods37"
=>

Unsere Website ist leider vorübergehend nicht verfügbar. Beide Standorte der Stabi sind geschlossen.

@dr0i
Copy link
Member Author

dr0i commented Jun 7, 2024

I would say we ignore them for now?

Not a good idea. Better to copy the data to a more stable place like our own server or this repo here like in jsonld-java/jsonld-java#175 (comment).

dr0i added a commit that referenced this pull request Jun 10, 2024
Thus we have more control over the data.
dr0i added a commit that referenced this pull request Jun 10, 2024
Thus we have more control over the data.
dr0i added a commit that referenced this pull request Jun 10, 2024
Thus we have more control over the data.
dr0i added a commit that referenced this pull request Jun 10, 2024
Thus we have more control over the data.
@dr0i dr0i force-pushed the 169-correctMfCoreBranch branch from 4e2dd0b to 72e0879 Compare June 10, 2024 14:06
@dr0i
Copy link
Member Author

dr0i commented Jun 10, 2024

I have updated the README to use the master-SNAPSHOT of MF-core, as in the project.clj.
Regarding the failing tests see #172.

@Phu2 Phu2 assigned dr0i and unassigned Phu2 Jun 11, 2024
@dr0i dr0i merged commit b5c80ca into main Jun 11, 2024
2 checks passed
@dr0i dr0i deleted the 169-correctMfCoreBranch branch June 11, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants