Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints for Gitcoin DAO #42

Open
thelastjosh opened this issue Feb 8, 2023 · 11 comments · May be fixed by #49
Open

Endpoints for Gitcoin DAO #42

thelastjosh opened this issue Feb 8, 2023 · 11 comments · May be fixed by #49
Labels

Comments

@thelastjosh
Copy link
Member

Pre-make some endpoints for the Gitcoin DAO, prior to the proposal going onto their forums.

@thelastjosh thelastjosh added the good first issue Good for newcomers label Feb 8, 2023
@DrewMcArthur
Copy link
Contributor

👋

@DrewMcArthur
Copy link
Contributor

so, as i understand it, (and please correct me if i'm wrong!), the task here is:

  • collect the information about gitcoin to fill out the form at https://daostar.org/register.
  • this will publish the EIP-4824-compliant JSON-LD file to IPFS, and we'll get a URI to that ipfs-hosted file.
  • then, once we have that URI, we'll be able to submit a proposal to gitcoin's governance to call daostar's Registration.sol contract, associating the gitcoin dao's onchain address with this IPFS URI.

does that all sound right? if so, the acceptance criteria for this issue would be a URI pointing to an IPFS-hosted JSON file containing info for the gitcoin dao.

@DrewMcArthur
Copy link
Contributor

i found:

again correct me if i'm wrong, but i'm just putting my thoughts in writing here - i'm guessing that in the registration form, the "DAO Contract Address" is that of the multisig wallet, and the manager could be entered as the maintainer's address?

etherscan has the tag #safe wallet on the multisig page, so i think that'd indicate this is a Safe-framework DAO. is there another way i could/should confirm that?

@DrewMcArthur
Copy link
Contributor

current question - for the members, activity log, proposals, and contract registry URIs, did i hear correctly that marking the contract as a Safe-framework DAO should auto populate those fields? or if i need to find those links, how can i find them?

thanks!

@asteroidb612
Copy link

@DrewMcArthur I'm looking into this too, and looked at this Aave implementation at Josh's suggestion. It seems for that proposal, the manager field was proposed to be the manager temporarily, but I could also see an argument for the maintainer as well.

@thelastjosh
Copy link
Member Author

Thanks for getting this rolling! Okay I can 100% tell you that Gitcoin DAO is not simply a safe multisig. It’s likely the token contract that contains the governance. Figure out what framework that governance uses. I believe it’s governor bravo but you should actually verify that for yourselves.

It it were just a Safe, yea you’d be able to just do use the current reference implementation. The registry flow would auto populate the relevant fields.

@DrewMcArthur DrewMcArthur linked a pull request Feb 23, 2023 that will close this issue
@DrewMcArthur
Copy link
Contributor

so i think i see what my next steps towards this are - i opened up a draft pr, #49 , which basically just creates some files. i also started some refactoring, but i'll pull that out into a separate PR so it's clear which is which.

@asteroidb612
Copy link

FYI - I'm stepping back from this to focus elsewhere.

@thelastjosh
Copy link
Member Author

Thanks for the heads up @asteroidb612

@DrewMcArthur let's figure out what the next steps are, I'll DM you my calendly.

If you posted an issue or feature request in the Gitcoin repo, would you mind linking that here?

Heads up, there's also some related work on developing other public goods / standards specifically for the Governor ecosystem (that Gitcoin DAO is part of). It might be relevant as context for this, especially if we use the Gitcoin endpoints as a basis for the reference implementation for the entire Governor ecosystem.

@thelastjosh
Copy link
Member Author

@DrewMcArthur what's the status of this currently? not sure if we ever scheduled a meeting. If you can make it to the strike team meetings at 11am ET every Thursday, would be great to chat about this.

@DrewMcArthur
Copy link
Contributor

@thelastjosh hi! sorry i have a conflicting recurring meeting at that time, unfortunately. latest status is commented on the PR, i believe the code is done but i'm not sure how to run the api server locally to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants