Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 10 second rate limiting on the wiki for bots. #44

Open
Ayushk4 opened this issue May 21, 2018 · 2 comments
Open

Remove the 10 second rate limiting on the wiki for bots. #44

Ayushk4 opened this issue May 21, 2018 · 2 comments
Labels
Hacktoberfest Issues that can be solved for Hacktoberfest

Comments

@Ayushk4
Copy link
Member

Ayushk4 commented May 21, 2018

Bots take 10 sec for every edited page as per the current limiting rate. When updating multiple pages via bots can be time-consuming.

For example:
In the case of blackjack bot, which updates the courses with new grade distribution, the no of courses 'updated' is approx 1000, so 10 sec gap extends the process to nearly 3 hrs.

@amrav
Copy link
Member

amrav commented May 21, 2018

We can reduce the rate limit to eg. 1 per second, but the point of the rate limit is to prevent a script from accidentally slowing down or taking offline the wiki for regular users. By comparison, it's okay for bots to take a relatively long time. This problem is particularly severe because I think we don't serve multiple requests concurrently, so fixing that is a good first step.

@Ayushk4
Copy link
Member Author

Ayushk4 commented May 22, 2018

Working on handling multiple requests concurrently would be good.

I overlooked the slowing wiki part but as per the current single request handling capability, the rate limit should not be reduced further. When I was running blackjack, it slept for any time between 9sec and 6 sec. If the rate limit is reduced by a lot factor, then it won't sleep in between edits, leaving way for handling other users' requests.

So, I too agree that serving requests concurrently should be prioritized.

@thealphadollar thealphadollar added the Hacktoberfest Issues that can be solved for Hacktoberfest label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues that can be solved for Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants