From 9258a81134c35bb9f1349568ea2bbb95763530b8 Mon Sep 17 00:00:00 2001 From: Aleksei Khudiakov Date: Wed, 10 Jan 2024 06:02:49 +1000 Subject: [PATCH 1/5] Do not remove QA tools after installer is done Signed-off-by: Aleksei Khudiakov --- src/MezzioInstaller/OptionalPackages.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/MezzioInstaller/OptionalPackages.php b/src/MezzioInstaller/OptionalPackages.php index ce2c721..dc13818 100644 --- a/src/MezzioInstaller/OptionalPackages.php +++ b/src/MezzioInstaller/OptionalPackages.php @@ -169,9 +169,6 @@ class OptionalPackages 'filp/whoops', 'jsoumelidis/zend-sf-di-config', 'mikey179/vfsstream', - 'laminas/laminas-coding-standard', - 'vimeo/psalm', - 'psalm/plugin-phpunit', 'mezzio/mezzio-fastroute', 'mezzio/mezzio-platesrenderer', 'mezzio/mezzio-twigrenderer', From 746a10c93b43548233094ffe7a83c71899ca3291 Mon Sep 17 00:00:00 2001 From: Aleksei Khudiakov Date: Wed, 10 Jan 2024 08:03:56 +1000 Subject: [PATCH 2/5] Keep QA tools configs Signed-off-by: Aleksei Khudiakov --- .gitattributes | 3 --- src/MezzioInstaller/OptionalPackages.php | 3 --- 2 files changed, 6 deletions(-) diff --git a/.gitattributes b/.gitattributes index 58eb9f9..aaeb573 100644 --- a/.gitattributes +++ b/.gitattributes @@ -2,7 +2,4 @@ /.github/ export-ignore /.laminas-ci.json export-ignore /composer.lock export-ignore -/phpcs.xml.dist export-ignore -/psalm.xml.dist export-ignore -/psalm-baseline.xml export-ignore /renovate.json export-ignore diff --git a/src/MezzioInstaller/OptionalPackages.php b/src/MezzioInstaller/OptionalPackages.php index dc13818..c61600e 100644 --- a/src/MezzioInstaller/OptionalPackages.php +++ b/src/MezzioInstaller/OptionalPackages.php @@ -115,9 +115,6 @@ class OptionalPackages '.laminas-ci.json', 'CHANGELOG.md', 'phpcs.xml', - 'phpcs.xml.dist', - 'psalm.xml.dist', - 'psalm-baseline.xml', 'renovate.json', 'src/App/templates/.gitkeep', ]; From c27696b546c1b2df1ec7997ad2aed9100457bcc9 Mon Sep 17 00:00:00 2001 From: Aleksei Khudiakov Date: Wed, 10 Jan 2024 09:48:41 +1000 Subject: [PATCH 3/5] Remove installer resources mention from psalm config on install Signed-off-by: Aleksei Khudiakov --- src/MezzioInstaller/OptionalPackages.php | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/MezzioInstaller/OptionalPackages.php b/src/MezzioInstaller/OptionalPackages.php index c61600e..ff839c1 100644 --- a/src/MezzioInstaller/OptionalPackages.php +++ b/src/MezzioInstaller/OptionalPackages.php @@ -607,6 +607,7 @@ private function cleanUp(): void $this->recursiveRmdir($this->projectRoot . 'docs'); $this->preparePhpunitConfig(); + $this->preparePsalmConfig(); } /** @@ -622,6 +623,19 @@ private function preparePhpunitConfig(): void file_put_contents($phpunitConfigFile, $phpunitConfig); } + /** + * Remove the MezzioInstaller exclusion from the psalm configuration + * + * @codeCoverageIgnore + */ + private function preparePsalmConfig(): void + { + $psalmConfigFile = $this->projectRoot . 'psalm.xml.dist'; + $psalmConfig = file_get_contents($psalmConfigFile); + $psalmConfig = $this->removeLinesContainingStrings(['MezzioInstaller'], $psalmConfig); + file_put_contents($psalmConfigFile, $psalmConfig); + } + /** * Prepare and ask questions and return the answer * From 84edc0f8bf8dc83bebabc49025c3031a467f8e34 Mon Sep 17 00:00:00 2001 From: Aleksei Khudiakov Date: Wed, 10 Jan 2024 09:58:13 +1000 Subject: [PATCH 4/5] Fix psalm complaint Signed-off-by: Aleksei Khudiakov --- src/MezzioInstaller/OptionalPackages.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/MezzioInstaller/OptionalPackages.php b/src/MezzioInstaller/OptionalPackages.php index ff839c1..a39588a 100644 --- a/src/MezzioInstaller/OptionalPackages.php +++ b/src/MezzioInstaller/OptionalPackages.php @@ -620,6 +620,9 @@ private function preparePhpunitConfig(): void $phpunitConfigFile = $this->projectRoot . 'phpunit.xml.dist'; $phpunitConfig = file_get_contents($phpunitConfigFile); $phpunitConfig = $this->removeLinesContainingStrings(['exclude', 'MezzioInstaller'], $phpunitConfig); + if ($phpunitConfig === null) { + return; + } file_put_contents($phpunitConfigFile, $phpunitConfig); } @@ -633,6 +636,9 @@ private function preparePsalmConfig(): void $psalmConfigFile = $this->projectRoot . 'psalm.xml.dist'; $psalmConfig = file_get_contents($psalmConfigFile); $psalmConfig = $this->removeLinesContainingStrings(['MezzioInstaller'], $psalmConfig); + if ($psalmConfig === null) { + return; + } file_put_contents($psalmConfigFile, $psalmConfig); } From 7bd2ac15d1abf053d7fa63e0c1dc527aa5cf4a0a Mon Sep 17 00:00:00 2001 From: Aleksei Khudiakov Date: Wed, 10 Jan 2024 09:58:52 +1000 Subject: [PATCH 5/5] Update baseline Signed-off-by: Aleksei Khudiakov --- psalm-baseline.xml | 22 ---------------------- psalm.xml.dist | 1 - 2 files changed, 23 deletions(-) diff --git a/psalm-baseline.xml b/psalm-baseline.xml index 48f2aca..751cde6 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -1,26 +1,5 @@ - - - $container - $factory - - - - - - - - - $factory - - - $factory - - - - - stabilityFlags]]> @@ -84,7 +63,6 @@ $content - $phpunitConfig install diff --git a/psalm.xml.dist b/psalm.xml.dist index 8287d7c..7bd1fe6 100644 --- a/psalm.xml.dist +++ b/psalm.xml.dist @@ -13,7 +13,6 @@ -