Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Failed to save "file name" automatically. Please save the file to make sure edits are retained #985

Open
DudeThatsErin opened this issue Jun 10, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@DudeThatsErin
Copy link

DudeThatsErin commented Jun 10, 2024

Describe the bug

I have Obsidian Tasks v7.4.0 and Kanban v2.0.51 and whenever I am creating a new card and the tasks pane pops up above the editor (I'll have another bug report on that one as it is always staying up) and I go to add anything like a due date or start date or whatever, it gives this error.

image
image
image

Debug Info:

SYSTEM INFO:
	Obsidian version: v1.6.3
	Installer version: v1.6.3
	Operating system: Windows 10 Home 10.0.22631
	Login status: logged in
	Catalyst license: supporter
	Insider build toggle: off
	Live preview: on
	Base theme: adapt to system
	Community theme: AnuPpuccin v1.5.0
	Snippets enabled: 4
	Restricted mode: off
	Plugins installed: 18
	Plugins enabled: 16
		1: BRAT v1.0.1
		2: Omnivore v1.10.3
		3: Settings Search v1.3.10
		4: Tasks v7.4.0
		5: Git v2.24.2
		6: Archiver v0.26.1
		7: Banners v2.0.5-beta
		8: Calendar v1.5.10
		9: Dataview v0.5.66
		10: Excalidraw v2.2.5
		11: Iconize v2.12.1
		12: Kanban v2.0.51
		13: Omnisearch v1.23.0
		14: Templater v2.3.3
		15: Style Settings v1.0.8
		16: Text Extractor v0.5.2

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Expected Behavior

No error should appear.

Steps to reproduce

  1. Install Tasks
  2. Restart Obsidian
  3. Install BRAT
  4. Set up Kanban in BRAT
  5. Restart Obsidian (for good measure)
  6. Create a Kanban Board
  7. Create a List
  8. Create a Card
  9. Add due date to said card
    Error should appear.

Relevant errors (if available)

No response

Operating system

Windows

@DudeThatsErin DudeThatsErin added the bug Something isn't working label Jun 10, 2024
@bluecav
Copy link

bluecav commented Jun 11, 2024

I just started trying to use this plugin, and hit the same issue. As you indicated, the tasks 7.4.0 plugin seems to be the cause of the issue. I actually think it's specific to the latest 7.4.0 update however.

I noticed in the last update that they enabled a new auto-suggest setting: https://publish.obsidian.md/tasks/Editing/Auto-Suggest#Details

In the document page, they said you can prevent it from being triggered by changing the Tasks setting for Global Task Filter to relying on using a tag to identify tasks that the plugin should manage.

It's annoying, but if you add #task in the input field, the menu no longer gets triggered by the TODO items that this plugin creates, and the bug goes away. The downside is past tasks would need this retroactively added.

I don't know if the resolution is in this plugin, or if the defect should go to the Tasks plugin to disable this dropdown when it's a Kanban page.

I added a comment to a discussion thread regarding Kanban integration to see if that was a way to notify them. Their bug reports appeared to have a template that only let you post if you indicated the issue persisted with no other plugins active.

@claremacrae
Copy link

In the document page, they said you can prevent it from being triggered by changing the Tasks setting for Global Task Filter to relying on using a tag to identify tasks that the plugin should manage.

it doesn’t say that. It said if you already use a global filter, then the task line needs to have the global filter in order for the menu to appear.

@mgmeyers
Copy link
Owner

@claremacrae It seems the issue here comes from these lines:

https://github.com/obsidian-tasks-group/obsidian-tasks/blob/7ca5c1163ddaec4ea8c5bd9c22a18ef2f3273d33/src/Suggestor/EditorSuggestorPopup.ts#L175-L181

The assumption here is that markdownFileInfo is an instance of MarkdownView which is not the case when editing a Kanban card (which is a KanbanView).

@claremacrae
Copy link

Ah that’s definitely new code added in the last release. Do you have ideas about how to enable the saving of the Kanban file there?

@claremacrae
Copy link

Ok so the workaround is definitely to revert to the previous version of Tasks for now then.

@claremacrae
Copy link

claremacrae commented Jun 11, 2024

I can probably make it so that Tasks doesn’t offer Dependency suggestions if the edits cannot be saved. Which will remove the requirement to be able to save the file.

But will unfortunately not be able to do any development or release in the next 10 days or so.

@claremacrae
Copy link

@DudeThatsErin Since this needs a change in the Tasks plugin, please feel free to log the issue there with full details, for visibility.

@claremacrae
Copy link

Another workaround: in the Tasks settings there is a checkbox “Auto-suggest task content”.

It should be possible to turn that off and disable the auto-suggest in Kanban, without the hack of adding a global filter.

@DudeThatsErin
Copy link
Author

@DudeThatsErin Since this needs a change in the Tasks plugin, please feel free to log the issue there with full details, for visibility.

I will do that in a moment. :) Sorry was AFK for a bit.

@claremacrae
Copy link

The fix for this is now released, in Tasks 7.5.0.

Apologies for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants