Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code in HandlerVisitorImplTest suggests that the return value of the HandlerStub calls is relevant #2

Open
mhdirkse opened this issue Jun 5, 2018 · 0 comments

Comments

@mhdirkse
Copy link
Owner

mhdirkse commented Jun 5, 2018

The class HandlerStubVisitorImpl calls a HandlerRunner instance. This HandlerRunner calls the right method on the generated handler interface; in the test this is HandlerStub. The testcode tests that the return value of HandlerRunner is properly used, but the interaction between the HandlerRunner and the HandlerStub is not tested. The code suggests otherwise, because the return value is specified in the constructor of HandlerStub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant