Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

universal-hex.iHexToCustomFormat() needs to protect against odd-length blocks #13

Open
microbit-carlos opened this issue May 5, 2020 · 0 comments
Open

universal-hex.iHexToCustomFormat() needs to protect against odd-length blocks #13

microbit-carlos opened this issue May 5, 2020 · 0 comments
Labels
todo

Comments

@microbit-carlos
Copy link
Collaborator

microbit-carlos commented May 5, 2020 •
edited
Loading

Maybe this won't be possible, but need to work out if we need to protect against this.

https://github.com/microbit-foundation/microbit-fb/blob/c2de9e0b1b1cdb17b1458dbf004d04101d292335/src/fat-binary.ts#L105
@microbit-carlos microbit-carlos changed the title fat-binary.iHexToCustomFormat() needs to protect against odd-length blocks universal-hex.iHexToCustomFormat() needs to protect against odd-length blocks Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@microbit-carlos