Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last block in a "section" of generated Universal Hex in block format is not padded #22

Open
microbit-carlos opened this issue Nov 6, 2020 · 0 comments

Comments

@microbit-carlos
Copy link
Collaborator

This was done as part of the original design, where the last block doesn't need to be padded as a the End Of File record would be place immediately after.

In the current configuration the Universal Hex first "section" last block is not padded.

// TODO: This test fails because the last block for a section is not padded
// expect(universalHexBlocks).toEqual(hexCombinedBlocks);

As the default implementation now uses only "sections" without the 512-byte blocks this issue is only present for uses actively using the block format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant