Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SummaryTree to distinguish it from ISummaryTree #4434

Closed
Tracked by #4683
agarwal-navin opened this issue Nov 20, 2020 · 6 comments
Closed
Tracked by #4683

Rename SummaryTree to distinguish it from ISummaryTree #4434

agarwal-navin opened this issue Nov 20, 2020 · 6 comments
Labels
ado Issue is tracked in the internal Azure DevOps backlog refactor Code refactoring and cleanup status: stale
Milestone

Comments

@agarwal-navin
Copy link
Contributor

These should be renamed as per #4403 (comment)

@curtisman
Copy link
Member

Related #4683

@curtisman curtisman added this to the Next milestone Jan 8, 2021
@ghost ghost added the status: stale label Jul 8, 2021
@ghost
Copy link

ghost commented Jul 8, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Jul 16, 2021
@agarwal-navin agarwal-navin reopened this Jul 16, 2021
@ghost ghost removed the status: stale label Jul 16, 2021
@arinwt
Copy link
Contributor

arinwt commented Jul 28, 2021

I feel like SummaryTree is really just Summary. That's the possible returned summary type (either handle or tree).

From the comment, it could look something like this:

old name old tree only new name new tree only
SummaryTree ISummaryTree Summary ISummaryTree
ISummarizeResult ISummaryTreeWithStats ISummaryWithStats ISummaryTreeWithStats
IContextSummarizeResult IChannelSummarizeResult ISummaryWithGcData ISummaryTreeWithGcData
ISummarizeInternalResult none ISummarizeInternalResult none

@agarwal-navin
Copy link
Contributor Author

that sounds good. summarize will stop returning GC data so the third row won't be needed anymore.

@ghost
Copy link

ghost commented Feb 7, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Feb 15, 2022
@agarwal-navin agarwal-navin reopened this Feb 15, 2022
@agarwal-navin agarwal-navin mentioned this issue May 26, 2022
8 tasks
@agarwal-navin agarwal-navin removed their assignment Jun 20, 2022
@curtisman curtisman added the ado Issue is tracked in the internal Azure DevOps backlog label Jun 20, 2022
@ghost ghost added the status: stale label Dec 18, 2022
@ghost
Copy link

ghost commented Dec 18, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Dec 26, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ado Issue is tracked in the internal Azure DevOps backlog refactor Code refactoring and cleanup status: stale
Projects
None yet
Development

No branches or pull requests

3 participants