Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

The document typo for C# tutorial (UWP) at "A custom signaling solution" session. #856

Open
JamestsaiTW opened this issue Mar 8, 2022 · 0 comments

Comments

@JamestsaiTW
Copy link

Describe the bug
https://microsoft.github.io/MixedReality-WebRTC/manual/cs/helloworld-cs-signaling-uwp.html

Document typos.

To Reproduce
Steps to reproduce the behavior:

At Step 4, code is:
private void Peer_LocalSdpReadytoSend(SdpMessage message) { var msg = NodeDssSignaler.FromSdpMessage(message); _signaler.SendMessageAsync(msg); }
private void Peer_IceCandidateReadytoSend(IceCandidate iceCandidate) { var msg = NodeDssSignaler.FromIceCandidate(iceCandidate); _signaler.SendMessageAsync(msg); }

image

Expected behavior
It should be:
private void Peer_LocalSdpReadytoSend(SdpMessage message) { var msg = NodeDssSignaler.Message.FromSdpMessage(message); _signaler.SendMessageAsync(msg); }
private void Peer_IceCandidateReadytoSend(IceCandidate iceCandidate) { var msg = NodeDssSignaler.Message.FromIceCandidate(iceCandidate); _signaler.SendMessageAsync(msg); }

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant