Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: == ligature joins together just like === #690

Open
coolCucumber-cat opened this issue Jun 19, 2023 · 2 comments
Open

Feature Request: == ligature joins together just like === #690

coolCucumber-cat opened this issue Jun 19, 2023 · 2 comments

Comments

@coolCucumber-cat
Copy link

Description of the new feature/enhancement (with images if possible)

So the ===, the !== and the != all have a ligature that joins the symbols together, I find it looks quite strange for just the == to be closer, but still not joined. Is it on purpose so you don't get it confused with a = ? Just my opinion but it would look cleaner that way.

Proposed technical implementation details

Either it could be part of the main ligatures or it could be its own separate own just like slashed zero. So in VSCode you could do: "editor.fontLigatures": "'zero', 'equals'" maybe, so that it's there if you want it. Also maybe could there be a ligature for => that isn't completely different to just a = and a > ?

@aaronbell
Copy link
Collaborator

It used to be like that and there were issues with people confusing == for =, leading to the break being added for better clarity. see: #284

I agree it could be a stylistic set, though, and will give that some thought.

@coolCucumber-cat
Copy link
Author

A lot of people on that issue were complaining about it too and the one thanking for the change got 11 thumbs down and 1 up. Plus if you don't like it, you can turn it off or there can be an option for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants