Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup container env for linux xdp #3854

Merged
merged 5 commits into from
Mar 21, 2024
Merged

setup container env for linux xdp #3854

merged 5 commits into from
Mar 21, 2024

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Sep 15, 2023

Description

Linux xdp dependencies

Testing

N/A

Documentation

not officially supported yet

@ami-GS ami-GS requested a review from a team as a code owner September 15, 2023 03:23
@ami-GS
Copy link
Contributor Author

ami-GS commented Sep 15, 2023

For some reason gcc-multilib is uninstalled at some point

@ami-GS ami-GS changed the title setup container env for lnux xdp setup container env for linux xdp Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (7bf265f) to head (a0beedd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3854      +/-   ##
==========================================
+ Coverage   84.22%   85.06%   +0.84%     
==========================================
  Files          56       56              
  Lines       15358    15358              
==========================================
+ Hits        12935    13065     +130     
+ Misses       2423     2293     -130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nibanks
nibanks previously approved these changes Sep 15, 2023
@nibanks nibanks dismissed their stale review September 15, 2023 12:01

test failure

@csujedihy
Copy link
Contributor

csujedihy commented Sep 19, 2023

For some reason gcc-multilib is uninstalled at some point

Didn't the docker build fail because it couldn't find ethertool?

And why are you still installing non-build related stuff on this docker image? e.g. iproute2, iptables and ethertool

And, btw, I have never heard of ethertool. The tool that's used to change NIC settings is called ethtool.

@@ -50,6 +64,12 @@ RUN wget -q https://packages.microsoft.com/config/ubuntu/18.04/packages-microsof
powershell \
&& rm -rf /var/lib/apt/lists/*

RUN wget -q https://github.com/libbpf/bpftool/releases/download/v7.2.0/bpftool-v7.2.0-amd64.tar.gz -O bpftool-amd64.tar.gz && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is bpftool needed for building the project?

Copy link
Contributor Author

@ami-GS ami-GS Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for building libxdp

@ami-GS
Copy link
Contributor Author

ami-GS commented Sep 19, 2023

What! the behavior differs with my local Ubuntu VM.
Ubuntu VM can not find gcc-multilib, Ubuntu container cannot find ethertool

@ami-GS
Copy link
Contributor Author

ami-GS commented Sep 21, 2023

The Build Nuget Package job is gotten affected by different PR?
#3819

@ami-GS ami-GS force-pushed the dev/daiki/linux_xdp_docker branch from 5f718f9 to f701cef Compare March 20, 2024 21:09
@@ -16,11 +16,8 @@ RUN apt-get update && apt-get install --no-install-recommends -y apt-transport-h
apt-add-repository ppa:lttng/stable-2.13 && \
apt-get update && apt-get install -y tzdata && apt-get install -y \
build-essential \
gcc-arm-linux-gnueabihf \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing these? they are needed for cross compile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc-multilib automatically removes these libraries, but leave these there makes installation failing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then you can't have gcc-multilib in this docker file or you will need to figure out a way to make it coexist with these libs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found the way to cover in CMakeLists.txt without installing gcc-multilib

@ami-GS ami-GS merged commit 0163551 into main Mar 21, 2024
349 of 352 checks passed
@ami-GS ami-GS deleted the dev/daiki/linux_xdp_docker branch March 21, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants