-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup container env for linux xdp #3854
Conversation
For some reason gcc-multilib is uninstalled at some point |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3854 +/- ##
==========================================
+ Coverage 84.22% 85.06% +0.84%
==========================================
Files 56 56
Lines 15358 15358
==========================================
+ Hits 12935 13065 +130
+ Misses 2423 2293 -130 ☔ View full report in Codecov by Sentry. |
Didn't the docker build fail because it couldn't find ethertool? And why are you still installing non-build related stuff on this docker image? e.g. iproute2, iptables and ethertool And, btw, I have never heard of ethertool. The tool that's used to change NIC settings is called ethtool. |
@@ -50,6 +64,12 @@ RUN wget -q https://packages.microsoft.com/config/ubuntu/18.04/packages-microsof | |||
powershell \ | |||
&& rm -rf /var/lib/apt/lists/* | |||
|
|||
RUN wget -q https://github.com/libbpf/bpftool/releases/download/v7.2.0/bpftool-v7.2.0-amd64.tar.gz -O bpftool-amd64.tar.gz && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is bpftool needed for building the project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, for building libxdp
What! the behavior differs with my local Ubuntu VM. |
The Build Nuget Package job is gotten affected by different PR? |
5f718f9
to
f701cef
Compare
.docker/ubuntu-22.04/Dockerfile
Outdated
@@ -16,11 +16,8 @@ RUN apt-get update && apt-get install --no-install-recommends -y apt-transport-h | |||
apt-add-repository ppa:lttng/stable-2.13 && \ | |||
apt-get update && apt-get install -y tzdata && apt-get install -y \ | |||
build-essential \ | |||
gcc-arm-linux-gnueabihf \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing these? they are needed for cross compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcc-multilib automatically removes these libraries, but leave these there makes installation failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then you can't have gcc-multilib in this docker file or you will need to figure out a way to make it coexist with these libs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found the way to cover in CMakeLists.txt without installing gcc-multilib
Description
Linux xdp dependencies
Testing
N/A
Documentation
not officially supported yet