install dotnet in prepare-machine.ps1 #4363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4363 +/- ##
==========================================
+ Coverage 84.27% 86.72% +2.45%
==========================================
Files 56 56
Lines 15426 17354 +1928
==========================================
+ Hits 13000 15051 +2051
+ Misses 2426 2303 -123 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
Jun 23, 2024
| @@ -15,5 +15,5 @@ if [ $sessionCreated -eq 0 ]; then | |||
| lttng destroy msquic | |||
|
|
|||
| babeltrace --names all $dirname/data > $dirname/quic.babel.txt | |||
| ./submodules/clog/src/clog2text/clog2text_lttng/bin/Release/net6.0/publish/clog2text_lttng -i $dirname/quic.babel.txt -s ./src/manifest/clog.sidecar -o $dirname/quic.log --showTimestamp --showCpuInfo | |||
| ./submodules/clog/src/clog2text/clog2text_lttng/bin/Debug/net6.0/publish/clog2text_lttng -i $dirname/quic.babel.txt -s ./src/manifest/clog.sidecar -o $dirname/quic.log --showTimestamp --showCpuInfo | |||
There was a problem hiding this comment.
pwsh ./scripts/prepare-machine.ps1 generates this Debug build automatically though
Maybe this
dotnet build (Join-Path $RootDir submodules clog)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Installing dotnet always hit known issue
https://learn.microsoft.com/en-us/dotnet/core/install/linux-package-mixup?pivots=os-linux-ubuntu
The cause should be because we already set repository for powershell which conflicts with the dotnet components.
Testing
Locally done
Documentation
N/A