Modifications in PR (4607) should not touch Core library #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4668 +/- ##
==========================================
+ Coverage 86.70% 86.78% +0.08%
==========================================
Files 56 56
Lines 17361 17361
==========================================
+ Hits 15053 15067 +14
+ Misses 2308 2294 -14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts the changes to msquichelper.h in PR https://github.com/microsoft/msquic/pull/4607/files#diff-8c815f8709f890481f7dca98690cabe22460b384b7e90da85d2cc0a42ee72cc1
because it wasn't clear why that change was made when the PR was about refactoring the Secnet tool.
Testing
CI
Documentation
N/A