Use global API table instead of each handle's having table ptr. #4708
+59
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Dec 13, 2024
nibanks
reviewed
Dec 13, 2024
| pub static mut API: Api = Api { table: ptr::null() }; | ||
|
|
||
| #[ctor::ctor] | ||
| fn open_msquic() { |
There was a problem hiding this comment.
It's unclear what calls this and when. Is this effectively called at DLL load (on Windows)?
There was a problem hiding this comment.
Is there a way to make this lazy initialized (when the first registration is created) instead of a global init?
nibanks
reviewed
Dec 13, 2024
Co-authored-by: Nick Banks <nibanks@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4708 +/- ##
==========================================
+ Coverage 85.64% 86.06% +0.42%
==========================================
Files 56 56
Lines 17363 17363
==========================================
+ Hits 14871 14944 +73
+ Misses 2492 2419 -73 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the
src/lib.rsfile and an update to theCargo.tomlfile. The primary focus is on removing thetablepointer from various structs and centralizing the API table management using a staticAPIinstance. Additionally, thectorcrate is introduced for constructor and destructor functions to manage the API lifecycle.Testing
cargo test
Documentation
No