Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylance import resolve messages should be pushed to Pyright #4701

Closed
rchiodo opened this issue Aug 8, 2023 · 1 comment
Closed

Pylance import resolve messages should be pushed to Pyright #4701

rchiodo opened this issue Aug 8, 2023 · 1 comment
Assignees
@rchiodo
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Aug 8, 2023

To make Pyright and Pylance be more consistent, we should make the import resolve errors that we're remapping to change the message for Pyright too.

The 'environment name' could default to the Python path for pyright, but for pylance, when it has the information, can get it from the Python core extension.
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Aug 8, 2023
@debonte debonte added enhancement New feature or request and removed needs repro Issue has not been reproduced yet labels Aug 14, 2023
@debonte debonte assigned rchiodo and unassigned debonte Aug 18, 2023
@rchiodo rchiodo added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Aug 25, 2023
@debonte
Copy link
Contributor

debonte commented Aug 31, 2023

This issue has been fixed in prerelease version 2023.8.51, which we've just released. You can find the changelog here: CHANGELOG.md

@debonte debonte closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rchiodo rchiodo

Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@debonte @rchiodo