Import suggestion should suggest collections.abc instead of typing for container types

[Kuba314]

Container types (e.g. Iterable, Collection, ...) in the typing module are deprecated since python 3.9 (see PEP 585). These symbols should be getting imported from collections.abc instead, but the python extension keeps suggesting importing them from the typing module.

[rchiodo]

Thanks for the suggestion. I suppose the downside is that these container types may eventually be removed from typing.

[erictraut]

It's unlikely these container types will ever be removed from typing. There's no significant upside to removing them (since they're just re-exports), and the downside would be huge because it would impact so much existing code.

[judej]

We need to investigate why the collections.abc is not being suggested.

[Kuba314]

Let me know if I could help you in any way. But I assume this issue happens to everyone, because I don't think I use any non-standard configuration other than being switched to a venv created by poetry.

[Avasam]

This feels like a possible duplicate of #3318 ?
Although I'm on 2023.11.13 and collections.abc is not being recommended to me:

[flying-sheep]

It's unlikely these container types will ever be removed from typing. There's no significant upside to removing them (since they're just re-exports), and the downside would be huge because it would impact so much existing code.

Where do you take this from? Core development guidelines or personal feelings about it? Because I don’t think everyone feels that way, so if there’s nothing confirming this, I doubt it’s the case:

“Deprecated” means “will be removed at some point” in every single project I ever saw it being defined, except for “never break userspace” Linux. I can imagine there’s a handful more projects like that. Python is not one of them.

This feels like a possible duplicate of #3318?
Although I'm on 2023.11.13 and collections.abc is not being recommended to me in:

Same for me. Either this or #3318 should therefore stay open until this is actually fixed.

[Tinche]

I was just about to report this issue. I'm using Ruff in almost all of my projects, and Ruff has a rule to flag importing deprecated symbols from typing.

So now using the import quick fix is a two step operation, have VS Code generate the import, and then have Ruff fix it. ;)

[Kuba314]

I'm on 2023.12.1 and I'm now getting both typing and collections.abc imports. I'm fine with there being both, so from my point of view this issue is now resolved.