Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Syntax Highlighting on v2024.14.0 #6358

Closed
axelmukwena opened this issue Sep 6, 2024 · 8 comments
Closed

No Syntax Highlighting on v2024.14.0 #6358

axelmukwena opened this issue Sep 6, 2024 · 8 comments
Assignees
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@axelmukwena
Copy link

axelmukwena commented Sep 6, 2024

Type: Bug

Behaviour

I'm running the latest Python extension v2024.14.0 which was released a few hours ago and I have lost syntax highlighting

Steps to reproduce:

  1. Only have Python and Pylance (auto-installed) installed
  2. Go to a file.py and hover over a Python variable and no highlighting. Imports are not highlighted, no command+click just to reference, etc
Screenshot 2024-09-06 at 1 09 07 PM
  1. If you downgrade, let's say to v2024.12.3, everything will work as expected
Screenshot 2024-09-06 at 1 08 47 PM

Diagnostic data

Nothing in the output panel

Extension version: 2024.14.0
VS Code version: Code 1.89.1 (Universal) (dc96b837cf6bb4af9cd736aa3af08cf8279f7685, 2024-05-07T05:14:24.611Z)
OS version: Darwin arm64 23.4.0
Modes:

  • Python version (& distribution if applicable, e.g. Anaconda): 3.10.11
  • Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
  • Value of the python.languageServer setting: Default
User Settings


languageServer: "Pylance"

Installed Extensions
Extension Name Extension Id Version
JavaScript Debugger ms-vscode.js-debug 1.89.0
JavaScript Debugger Companion Extension ms-vscode.js-debug-companion 1.1.2
Pylance ms-python.vscode-pylance 2024.8.2
Python ms-python.python 2024.14.0
Table Visualizer for JavaScript Profiles ms-vscode.vscode-js-profile-table 1.0.9
System Info
Item Value
CPUs Apple M3 Pro (11 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 2, 2, 2
Memory (System) 18.00GB (0.25GB free)
Process Argv --crash-reporter-id ad33eb45-3e2b-41ab-882a-2c8d90996c0a
Screen Reader no
VM 0%
A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
bdiig495:31013172
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
2f103344:31071589
impr_priority:31102340
refactort:31108082
pythonrstrctxt:31112756
wkspc-onlycs-t:31132770
wkspc-ranged-t:31125599
fje88620:31121564

@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Sep 6, 2024
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Sep 6, 2024
@rchiodo
Copy link
Contributor

rchiodo commented Sep 6, 2024

There should be an error in the Python Language Server output that says this:

2024-09-06 09:37:45.381 [info] The language client requires VS Code version ^1.91.0 but received version 1.89.1

You would need to upgrade VS code to the latest version to use the newer Python/Pylance extension.

@rchiodo
Copy link
Contributor

rchiodo commented Sep 6, 2024

Internally we need to mark our engine version for both extensions to 1.91. Meaning we have a bug here in that we currently allow 1.89 for both extensions.

@rchiodo rchiodo added bug Something isn't working and removed needs repro Issue has not been reproduced yet labels Sep 6, 2024
@rchiodo rchiodo assigned rchiodo and unassigned KacieKK Sep 6, 2024
@rchiodo rchiodo added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Sep 9, 2024
@IamRezaMousavi
Copy link

@rchiodo I have similar bug:

As you can see, all libraries and variables are used:

x
y

@rchiodo
Copy link
Contributor

rchiodo commented Sep 10, 2024

@rchiodo I have similar bug:

As you can see, all libraries and variables are used:

x y

@IamRezaMousavi , I don't think your issue is the same. The root cause of the original issue is that Pylance requires the latest VS code now. I'm not sure what your problem is. It looks correct to me. Colorization is different for assignment vs usage.

@IamRezaMousavi
Copy link

@rchiodo I have similar bug:
As you can see, all libraries and variables are used:
x y

@IamRezaMousavi , I don't think your issue is the same. The root cause of the original issue is that Pylance requires the latest VS code now. I'm not sure what your problem is. It looks correct to me. Colorization is different for assignment vs usage.

  • imported socket in line 3 and used in line 21
  • assigned udp_port in line 19 and used in line 22
  • assigned addr in line 28 and used in line 29
  • assigned data_dict in line 34 and used in line 38
  • And many other...

These items have wrong colors

@rchiodo
Copy link
Contributor

rchiodo commented Sep 11, 2024

I'll open a separate issue. It's still not the same as this one.

See this issue:
#6379

@StellaHuang95
Copy link
Contributor

This issue has been fixed in prerelease version 2024.9.100, which we've just released. You can find the changelog here: CHANGELOG.md

@axelmukwena
Copy link
Author

Thank you @StellaHuang95 🥬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

5 participants