Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show errors in stdlib files #6453

Open
mjbvz opened this issue Sep 24, 2024 · 12 comments
Open

Don't show errors in stdlib files #6453

mjbvz opened this issue Sep 24, 2024 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@mjbvz
Copy link

mjbvz commented Sep 24, 2024

  1. Turn on analysis
  2. Run go to definition on join from os.path

Bug
My problem count explodes:

Image

I wouldn't expect analysis to kick in for files from the standard library like this

@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Sep 25, 2024
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Sep 25, 2024
@rchiodo
Copy link
Contributor

rchiodo commented Sep 25, 2024

I would hazard a guess that you have a pyproject.toml or a pyrightconfig.json? The errors are likely a result of this:
https://github.com/microsoft/pylance-release/wiki/Settings.json-overridden-by-Pyrightconfig.json-or-Pyproject.toml

It's forcing your typecheckingmode to default to 'basic'

@mjbvz
Copy link
Author

mjbvz commented Sep 25, 2024

I'm pretty sure I just turned on type checking from the language status menu. I don't see those files in my project

Image

@rchiodo
Copy link
Contributor

rchiodo commented Sep 25, 2024

That's expected behavior then. typeCheckingMode applies to all open files, regardless of if they're under a workspace folder or not.

What you're asking for is typechecking only on 1st party source and not 3rd party source it seems like? Seems reasonable to me. Why would anybody care to type check code that isn't their own?

@rchiodo
Copy link
Contributor

rchiodo commented Sep 25, 2024

One way to workaround this is to add a glob to the 'ignore' setting:

"python.analysis.ignore": ["${workspaceFolder}/venv/**/*"]

@rchiodo
Copy link
Contributor

rchiodo commented Sep 25, 2024

Maybe we should add all of the site-packages folders to the default ignore list?

@heejaechang
Copy link
Contributor

we show errors from any file opened in vscode. if your go to def opened a file, we will show errors on that file as long as it stays as open. once you close that file, they will go away. and that behavior is by design to support orphan files opened in editor along with folder

you could request enhancement request though. and we see how many upvote we get.

@mjbvz
Copy link
Author

mjbvz commented Sep 25, 2024

Feels like this scenario is common enough that ignoring the standard library would be a reasonable default. When would you want these errors to show up?

@heejaechang
Copy link
Contributor

heejaechang commented Oct 3, 2024

standard library typeshed authors? it would be nice to have a way to categorize problems in UI. so less important errors can group differently than other more important errors.

@mjbvz
Copy link
Author

mjbvz commented Oct 3, 2024

standard library typeshed authors?

Having an option (with no errors reported by default) seems reasonable for the majority of users

@heejaechang
Copy link
Contributor

we could add an option for it, but usually user doesn't leave stdlib file open for long time? they usually either open it to see some definition/signature and close it. what is the scenario where you leave them open for long time?

@mjbvz
Copy link
Author

mjbvz commented Oct 3, 2024

Yes that's exactly the problem I ran into:

  1. Run go to def on stdlib symbol to quickly browse the code
  2. File opens and I am flooded with 100+ errors
  3. The errors do go away after I close the file but it's distracting to suddenly have that many errors appear and also distracting to see all the red lines highlighted in the stdlib file

@heejaechang heejaechang added enhancement New feature or request and removed needs repro Issue has not been reproduced yet labels Oct 3, 2024
@Ravencentric
Copy link

I would love to see everything in stdlib/venv get excluded. It's just pointless distraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants