Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlineChat.viewInChat command from notebook will cause pylance to crash #6454

Open
amunger opened this issue Sep 25, 2024 · 5 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@amunger
Copy link

amunger commented Sep 25, 2024

  1. open a notebook and press ctrl+i to open the copilot inline chat
  2. ask for a code change and then run inlineChat.viewInChat on the response (ctrl+down)
    🐛 pylance crashes with bad request
2024-09-25 12:59:22.351 [error] Request textDocument/documentSymbol failed with message: Debug Failure. Notebook file should not be passed to getWorkspaceForFile: vscode-chat-code-block:/c%3A/src/test/ws1/1.ipynb?25fea62c-6c24-498f-993c-46a83def7b6f: Error: Request textDocument/documentSymbol failed with message: Debug Failure. Notebook file should not be passed to getWorkspaceForFile: vscode-chat-code-block:/c%3A/src/test/ws1/1.ipynb?25fea62c-6c24-498f-993c-46a83def7b6f
    at ae (c:\Users\aaron\.vscode-insiders\extensions\ms-python.python-2024.15.2024092501-win32-arm64\out\client\extension.js:2:2052314)
    at oe (c:\Users\aaron\.vscode-insiders\extensions\ms-python.python-2024.15.2024092501-win32-arm64\out\client\extension.js:2:2050274)
    at Immediate.<anonymous> (c:\Users\aaron\.vscode-insiders\extensions\ms-python.python-2024.15.2024092501-win32-arm64\out\client\extension.js:2:2046568)
    at processImmediate (node:internal/timers:483:21)
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Sep 25, 2024
@StellaHuang95 StellaHuang95 added bug Something isn't working and removed needs repro Issue has not been reproduced yet labels Sep 26, 2024
@StellaHuang95
Copy link
Contributor

Thanks for reporting, I am able to repro this.

@rchiodo
Copy link
Contributor

rchiodo commented Sep 30, 2024

Moving to triage, I think we might want to fix this before we ship?

@StellaHuang95
Copy link
Contributor

Not sure how many people are using it, this issue only repros when user clicks View in Chat in a notebook file. But I agree it's something we should fix sooner rather than later.
Image

@rchiodo
Copy link
Contributor

rchiodo commented Sep 30, 2024

THe notebook in the chat window is messed up too for me. Maybe the chat window is passing the wrong file? Shouldn't it be passing us the cell and not the file?

Image

@StellaHuang95
Copy link
Contributor

Maybe the scheme is not supported? Running the same command in a regular python file doesn't crash Pylance but gives me a silent error. [Error - 10:54:20 AM] (25168) File or directory "vscode-chat-code-block:/" does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants