Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code that checks whether user has set certain settings explicitly or not is broken when pyrightconfig/pyproject exists #6499

Open
heejaechang opened this issue Sep 30, 2024 · 2 comments
Assignees
Labels
needs repro Issue has not been reproduced yet

Comments

@heejaechang
Copy link
Contributor

Environment data

  • Pylance version: 2024.9.102

Pylance has code to see whether certain settings are set by users explicitly or not when applying different default values for each settings.

currently that logic only checks vscode's settings.json but not pyrightconfig/pyproject wrongly assuming certain settings are not set explicitly.

issue is found through code but not through set repro steps.

@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Sep 30, 2024
@rchiodo
Copy link
Contributor

rchiodo commented Sep 30, 2024

Are you referring to the logic you added about whether or not a setting is set to default?

@heejaechang
Copy link
Contributor Author

yep. that only checks vscode's settings but not pyright/pyproject files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs repro Issue has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

2 participants