Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground Win32 isn't documented #8649

Closed
chrisglein opened this issue Sep 17, 2021 · 5 comments · Fixed by #8686
Closed

Playground Win32 isn't documented #8649

chrisglein opened this issue Sep 17, 2021 · 5 comments · Fixed by #8686
Assignees
@chiaramooney
Labels
Documentation enhancement
Milestone
Backlog

Comments

@chrisglein
Copy link
Member

There's a readme for Playground, but it doesn't acknowledge Playground Win32. Given that this app is useful as an example for unpackaged apps and Xaml Islands, it at least deserves some coverage in the folder readmes about how to run it. At least until we create a replacement (see this issue)
@chrisglein chrisglein added this to the Backlog milestone Sep 17, 2021
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 17, 2021
@chrisglein chrisglein added Documentation and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Sep 20, 2021
@chiaramooney chiaramooney mentioned this issue Sep 22, 2021
Merged
@asklar
Copy link
Member

asklar commented Sep 22, 2021

To me this is by design, per discussion in microsoft/react-native-windows-samples#267

@chiaramooney
Copy link
Contributor

Looks like my PR got closed from inactivity. @chrisglein @asklar do we have a final decision here on if we want this documentation or not? If yes, I'll reopen the PR. Otherwise, I'll go ahead and close this issue to wrap up this issue.

@chrisglein
Copy link
Member Author

Yep, we talked about it in October-ish. You can reopen the PR.

@chiaramooney
Copy link
Contributor

Will do. @asklar @chrisglein PR reopened now. Currently it's flagged with 'changes requested', so it'll need those removed before I can merge.

@chiaramooney chiaramooney reopened this Jan 14, 2022
@chrisglein
Copy link
Member Author

Will do. @asklar Alexander Sklar FTE @chrisglein Chris Glein FTE PR reopened now. Currently it's flagged with 'changes requested', so it'll need those removed before I can merge.

@asklar Can you refresh you review state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chiaramooney chiaramooney

Labels
Documentation enhancement
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Update Playground Readme to Include Playground-win32 chiaramooney/react-native-windows
3 participants
@asklar @chrisglein @chiaramooney