Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'imageSelectionBorderColor' config doesn't take effect in Safari #2676

Closed
Rain-Zheng opened this issue May 31, 2024 · 2 comments
Closed

'imageSelectionBorderColor' config doesn't take effect in Safari #2676

Rain-Zheng opened this issue May 31, 2024 · 2 comments

Comments

@Rain-Zheng
Copy link
Contributor

Describe the bug
In Safari, the image border color is always blue, regardless of the value of imageSelectionBorderColor:

Safari Chrome
image image

It seems that if the outline-style is set to auto, the outline-color won't take effect.

To Reproduce
Steps to reproduce the behavior:

  1. Open roosterjs demo page
  2. Insert an image and cilck it
  3. Check the border's color

Expected behavior
The border's color should respect to the value of imageSelectionBorderColor.

Device Information

  • OS: MacOS 14
  • Browser: Safari
  • Version: 17.5
@JiuqingSong
Copy link
Collaborator

Hi, thanks for reporting. Do you want to submit a fix?

@JiuqingSong JiuqingSong mentioned this issue Jun 3, 2024
Merged
@JiuqingSong
Copy link
Collaborator

This should have been fixed by #2670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JiuqingSong @Rain-Zheng