You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the issue
In PR #33188 I made the mistake of adjusting the version number but forgot to reset the port number. This was also overlooked when reviewing. Since I used x-add-version this time to adjust all the other files, I didn't notice it either, since this way you don't have to manually write the version and port number again.
To Reproduce
Adjust the version in a vcpkg.json, but keep the old port number (uneven 0 for this test)
Commit changes
Call x-add-version => No hint, that the port number is wrong
Expected behavior
When calling x-add-version should check the version json, before adjusting the file:
New version is equal to previous one? Port number should be previous port numebr + 1
New version is not equal to previous one? Port number should be 0
In case these rules are violated the vcpkg-tool should reject to adjust the files.
Note: This should be also checked the CI (comparing just the last two versions as I believe you can't fix older issues).
category:vcpkg-featureThe issue is a new capability of the tool that doesn’t already exist and we haven’t committed
1 participant
Converted from issue
This discussion was converted from issue #33257 on March 08, 2024 02:06.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Describe the issue
In PR #33188 I made the mistake of adjusting the version number but forgot to reset the port number. This was also overlooked when reviewing. Since I used
x-add-version
this time to adjust all the other files, I didn't notice it either, since this way you don't have to manually write the version and port number again.To Reproduce
vcpkg.json
, but keep the old port number (uneven0
for this test)x-add-version
=> No hint, that the port number is wrongExpected behavior
When calling
x-add-version
should check the version json, before adjusting the file:0
In case these rules are violated the vcpkg-tool should reject to adjust the files.
Note: This should be also checked the CI (comparing just the last two versions as I believe you can't fix older issues).
Beta Was this translation helpful? Give feedback.
All reactions